automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: John Daley <johndale@cisco.com>
Subject: [dpdk-test-report] |WARNING| pw31092 [PATCH] net/enic: fix TSO for packets greater than 9208 bytes
Date: Thu,  2 Nov 2017 03:00:24 +0100 (CET)	[thread overview]
Message-ID: <20171102020024.874A91B392@dpdk.org> (raw)
In-Reply-To: <20171102015908.6953-1-johndale@cisco.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31092

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pkt_len > ENIC_TX_MAX_PKT_SIZE'
#71: FILE: drivers/net/enic/enic_rxtx.c:570:
+		if (unlikely(!tso && (pkt_len > ENIC_TX_MAX_PKT_SIZE))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'header_len == 0'
#90: FILE: drivers/net/enic/enic_rxtx.c:599:
+			if (unlikely((header_len == 0) || ((tx_pkt->tso_segsz +
+			    header_len) > ENIC_TX_MAX_PKT_SIZE))) {

total: 0 errors, 0 warnings, 2 checks, 54 lines checked

           reply	other threads:[~2017-11-02  2:00 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20171102015908.6953-1-johndale@cisco.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102020024.874A91B392@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=johndale@cisco.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).