From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 73B0A1B3AA; Thu,  2 Nov 2017 09:44:17 +0100 (CET)
In-Reply-To: <1509612210-5499-1-git-send-email-hejianet@gmail.com>
References: <1509612210-5499-1-git-send-email-hejianet@gmail.com>
To: test-report@dpdk.org
Cc: Jia He <hejianet@gmail.com>
Message-Id: <20171102084417.73B0A1B3AA@dpdk.org>
Date: Thu,  2 Nov 2017 09:44:17 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31096 [PATCH v2] ring: guarantee
	ordering of cons/prod loading when doing
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Nov 2017 08:44:17 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31096

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#86: FILE: lib/librte_ring/rte_ring.h:111:
+ * It depends on performance test results. */

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#219: FILE: lib/librte_ring/rte_ring_arm64.h:41:
+#define arch_rte_atomic_load(a, b) \
+	*(a); \
+	rte_smp_rmb()

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#268: FILE: lib/librte_ring/rte_ring_generic.h:36:
+#define arch_rte_atomic_load(a, b) *(a)

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#269: FILE: lib/librte_ring/rte_ring_generic.h:37:
+#define arch_rte_atomic_store(a, b, c) \
+do { \
+	*(a) = b; \
+} while(0)

ERROR:SPACING: space required before the open parenthesis '('
#272: FILE: lib/librte_ring/rte_ring_generic.h:40:
+} while(0)

total: 3 errors, 2 warnings, 190 lines checked