From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 7D6161B656; Thu,  2 Nov 2017 17:10:03 +0100 (CET)
In-Reply-To: <20171102160924.41266-7-roy.fan.zhang@intel.com>
References: <20171102160924.41266-7-roy.fan.zhang@intel.com>
To: test-report@dpdk.org
Cc: Fan Zhang <roy.fan.zhang@intel.com>
Message-Id: <20171102161003.7D6161B656@dpdk.org>
Date: Thu,  2 Nov 2017 17:10:03 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31120 [PATCH RFC 6/6]
	example/vhost_crypto: add vhost_crypto sample application
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Nov 2017 16:10:03 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31120

_coding style issues_


WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#144: FILE: examples/vhost_crypto/main.c:48:
+#define MAX_PKT_BURST ^I^I^I(64) /**< Max burst size for RX/TX */$

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#345: FILE: examples/vhost_crypto/main.c:249:
+static const struct vhost_device_ops virtio_crypto_device_ops =
+{

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#351: FILE: examples/vhost_crypto/main.c:255:
+/*
+static void clrscr(void)

WARNING:TYPO_SPELLING: 'Procesing' may be misspelled - perhaps 'Processing'?
#489: FILE: examples/vhost_crypto/main.c:393:
+	RTE_LOG(INFO, USER1, "Procesing on Core %u started
", lcore_id);

ERROR:SPACING: spaces required around that '=' (ctx:WxV)
#491: FILE: examples/vhost_crypto/main.c:395:
+	ret =rte_cryptodev_configure(info.cid, &config);
 	    ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#628: FILE: examples/vhost_crypto/main.c:532:
+	if (ret < 0) {
+		rte_exit(EXIT_FAILURE, "Failed to parse arguments!
");
+	}

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#676: FILE: examples/vhost_crypto/main.c:580:
+	if (rte_eal_remote_launch(vhost_crypto_stats_worker, NULL, stats_lcore)
[...]
+		 {

WARNING:TABSTOP: Statements should start on a tabstop
#678: FILE: examples/vhost_crypto/main.c:582:
+		 {

total: 2 errors, 6 warnings, 676 lines checked