From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Fan Zhang <roy.fan.zhang@intel.com>
Subject: [dpdk-test-report] |WARNING| pw31140 [PATCH RFC v2 7/7] example/vhost_crypto: add vhost_crypto sample application
Date: Thu, 2 Nov 2017 21:12:18 +0100 (CET) [thread overview]
Message-ID: <20171102201218.263B81B66B@dpdk.org> (raw)
In-Reply-To: <20171102201059.2803-8-roy.fan.zhang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31140
_coding style issues_
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#144: FILE: examples/vhost_crypto/main.c:48:
+#define MAX_PKT_BURST ^I^I^I(64) /**< Max burst size for RX/TX */$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#345: FILE: examples/vhost_crypto/main.c:249:
+static const struct vhost_device_ops virtio_crypto_device_ops =
+{
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#351: FILE: examples/vhost_crypto/main.c:255:
+/*
+static void clrscr(void)
WARNING:TYPO_SPELLING: 'Procesing' may be misspelled - perhaps 'Processing'?
#489: FILE: examples/vhost_crypto/main.c:393:
+ RTE_LOG(INFO, USER1, "Procesing on Core %u started
", lcore_id);
ERROR:SPACING: spaces required around that '=' (ctx:WxV)
#491: FILE: examples/vhost_crypto/main.c:395:
+ ret =rte_cryptodev_configure(info.cid, &config);
^
WARNING:BRACES: braces {} are not necessary for single statement blocks
#628: FILE: examples/vhost_crypto/main.c:532:
+ if (ret < 0) {
+ rte_exit(EXIT_FAILURE, "Failed to parse arguments!
");
+ }
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#676: FILE: examples/vhost_crypto/main.c:580:
+ if (rte_eal_remote_launch(vhost_crypto_stats_worker, NULL, stats_lcore)
[...]
+ {
WARNING:TABSTOP: Statements should start on a tabstop
#678: FILE: examples/vhost_crypto/main.c:582:
+ {
total: 2 errors, 6 warnings, 676 lines checked
parent reply other threads:[~2017-11-02 20:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171102201059.2803-8-roy.fan.zhang@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102201218.263B81B66B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=roy.fan.zhang@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).