[dpdk-test-report] |WARNING| pw31206 [PATCH 1/2] net/ixgbe: add and export MDIO APIs

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shweta Choudaha <shweta.choudaha@gmail.com>
Subject: [dpdk-test-report] |WARNING| pw31206 [PATCH 1/2] net/ixgbe: add and export MDIO APIs
Date: Mon,  6 Nov 2017 14:44:07 +0100 (CET)	[thread overview]
Message-ID: <20171106134407.638B01B2C9@dpdk.org> (raw)
In-Reply-To: <CAActUde0yVGSXcdE3enLLr5GQZ_5SeUU83zVGeJCOEORtxqqAg@mail.gmail.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31206

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#38: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1046:
+                     struct ixgbe_phy_info **phy)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#38: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1046:
+                     struct ixgbe_phy_info **phy)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#40: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1048:
+    struct rte_eth_dev *dev;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#42: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1050:
+    *hw = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#43: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1051:
+    *phy = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#45: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1053:
+    dev = &rte_eth_devices[port];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#46: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1054:
+    if (!is_ixgbe_supported(dev))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#47: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1055:
+        return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#47: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1055:
+        return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#49: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1057:
+    *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#50: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1058:
+    if (!*hw)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#51: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1059:
+        return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#51: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1059:
+        return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#53: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1061:
+    *phy = &(*hw)->phy;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#58: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1066:
+            uint32_t dev_type, uint16_t *phy_data)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#58: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1066:
+            uint32_t dev_type, uint16_t *phy_data)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#60: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1068:
+    struct ixgbe_hw *hw;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#61: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1069:
+    struct ixgbe_phy_info *phy;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#63: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1071:
+    RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#65: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1073:
+    rte_pmd_ixgbe_get_hw_phy(port, &hw, &phy);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#67: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1075:
+    if (!hw || !phy)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#68: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1076:
+        return -ENOTSUP;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#68: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1076:
+        return -ENOTSUP;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#70: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1078:
+    return phy->ops.read_reg_mdi(hw, reg_addr, dev_type, phy_data);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#75: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1083:
+             uint32_t dev_type, uint16_t phy_data)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#75: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1083:
+             uint32_t dev_type, uint16_t phy_data)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#77: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1085:
+    struct ixgbe_hw *hw;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#78: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1086:
+    struct ixgbe_phy_info *phy;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#80: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1088:
+    RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#82: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1090:
+    rte_pmd_ixgbe_get_hw_phy(port, &hw, &phy);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#84: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1092:
+    if (!hw || !phy)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#85: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1093:
+        return -ENOTSUP;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1093:
+        return -ENOTSUP;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#87: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:1095:
+    return phy->ops.write_reg_mdi(hw, reg_addr, dev_type, phy_data);$

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#95: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.h:600:
port, uint32_t *wd_timeout);

ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.h:622:
+            uint32_t dev_type, uint16_t *phy_data);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.h:622:
+            uint32_t dev_type, uint16_t *phy_data);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.h:642:
+             uint32_t dev_type, uint16_t phy_data);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.h:642:
+             uint32_t dev_type, uint16_t phy_data);$

total: 10 errors, 29 warnings, 0 checks, 112 lines checked

          parent reply	other threads:[~2017-11-06 13:44 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <CAActUde0yVGSXcdE3enLLr5GQZ_5SeUU83zVGeJCOEORtxqqAg@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171106134407.638B01B2C9@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=shweta.choudaha@gmail.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).