From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: [dpdk-test-report] |WARNING| pw31224 [PATCH v2] ring: guarantee ordering of cons/prod loading when doing
Date: Tue, 7 Nov 2017 05:38:43 +0100 (CET) [thread overview]
Message-ID: <20171107043843.E78FD1B388@dpdk.org> (raw)
In-Reply-To: <20171107043655.GA3244@jerin>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31224
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#26:
> Subject: Re: [PATCH v2] ring: guarantee ordering of cons/prod loading when
ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#69:
@@ -470,9 +474,8 @@ __rte_ring_do_enqueue(struct rte_ring *r, void *
ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#108: FILE: lib/librte_ring/rte_ring.h:357:
*r);
ERROR:CODE_INDENT: code indent should use tabs where possible
#114: FILE: lib/librte_ring/rte_ring.h:361:
+ uint32_t single, const uint32_t enqueue)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: lib/librte_ring/rte_ring.h:361:
+ uint32_t single, const uint32_t enqueue)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: lib/librte_ring/rte_ring.h:363:
+ if (enqueue)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#116: FILE: lib/librte_ring/rte_ring.h:363:
+ if (enqueue)
+ rte_smp_wmb();
ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: lib/librte_ring/rte_ring.h:364:
+ rte_smp_wmb();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: lib/librte_ring/rte_ring.h:364:
+ rte_smp_wmb();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: lib/librte_ring/rte_ring.h:365:
+ else$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#118: FILE: lib/librte_ring/rte_ring.h:365:
+ else
+ rte_smp_rmb();
ERROR:CODE_INDENT: code indent should use tabs where possible
#119: FILE: lib/librte_ring/rte_ring.h:366:
+ rte_smp_rmb();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: lib/librte_ring/rte_ring.h:366:
+ rte_smp_rmb();$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 6 errors, 8 warnings, 13 lines checked
parent reply other threads:[~2017-11-07 4:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171107043655.GA3244@jerin>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107043843.E78FD1B388@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).