automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw31280 [PATCH RFC 1/2] lib: introduce raw device library
Date: Wed,  8 Nov 2017 18:42:01 +0100 (CET)	[thread overview]
Message-ID: <20171108174201.1A5E21B2E0@dpdk.org> (raw)
In-Reply-To: <1510162854-10171-2-git-send-email-hemant.agrawal@nxp.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31280

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxB)
#1318: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:60:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1319: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:61:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1324: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:66:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1325: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:67:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1331: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:73:
+#define RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, retval) do { \
+	if (!rte_rawdev_pmd_is_valid_dev((dev_id))) { \
+		RTE_RDEV_LOG_ERR("Invalid dev_id=%d
", dev_id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1338: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:80:
+#define RTE_RAWDEV_VALID_DEVID_OR_RET(dev_id) do { \
+	if (!rte_rawdev_pmd_is_valid_dev((dev_id))) { \
+		RTE_RDEV_LOG_ERR("Invalid dev_id=%d
", dev_id); \
+		return; \
+	} \
+} while (0)

total: 4 errors, 2 warnings, 1771 lines checked

           reply	other threads:[~2017-11-08 17:42 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1510162854-10171-2-git-send-email-hemant.agrawal@nxp.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108174201.1A5E21B2E0@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).