From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 1A5E21B2E0; Wed,  8 Nov 2017 18:42:01 +0100 (CET)
In-Reply-To: <1510162854-10171-2-git-send-email-hemant.agrawal@nxp.com>
References: <1510162854-10171-2-git-send-email-hemant.agrawal@nxp.com>
To: test-report@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Message-Id: <20171108174201.1A5E21B2E0@dpdk.org>
Date: Wed,  8 Nov 2017 18:42:01 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31280 [PATCH RFC 1/2] lib: introduce
	raw device library
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Nov 2017 17:42:01 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31280

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxB)
#1318: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:60:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1319: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:61:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1324: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:66:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1325: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:67:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1331: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:73:
+#define RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, retval) do { \
+	if (!rte_rawdev_pmd_is_valid_dev((dev_id))) { \
+		RTE_RDEV_LOG_ERR("Invalid dev_id=%d
", dev_id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1338: FILE: lib/librte_rawdev/rte_rawdev_pmd.h:80:
+#define RTE_RAWDEV_VALID_DEVID_OR_RET(dev_id) do { \
+	if (!rte_rawdev_pmd_is_valid_dev((dev_id))) { \
+		RTE_RDEV_LOG_ERR("Invalid dev_id=%d
", dev_id); \
+		return; \
+	} \
+} while (0)

total: 4 errors, 2 warnings, 1771 lines checked