From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Edward Makarov <makarov@kraftway.ru>
Subject: [dpdk-test-report] |WARNING| pw31348 [PATCH] net/mlx5: fix use of bit numbers instead of masks
Date: Fri, 10 Nov 2017 15:18:58 +0100 (CET) [thread overview]
Message-ID: <20171110141858.E70A01B6FB@dpdk.org> (raw)
In-Reply-To: <20171110141746.19251-1-makarov@kraftway.ru>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31348
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_Autoneg_BIT>
#39: FILE: drivers/net/mlx5/mlx5_ethdev.c:868:
+ if (sc & MLX5_BITSHIFT(ETHTOOL_LINK_MODE_Autoneg_BIT))
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_1000baseT_Full_BIT>
#43: FILE: drivers/net/mlx5/mlx5_ethdev.c:870:
+ if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_1000baseT_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_1000baseKX_Full_BIT>
#44: FILE: drivers/net/mlx5/mlx5_ethdev.c:871:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_1000baseKX_Full_BIT)))
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT>
#49: FILE: drivers/net/mlx5/mlx5_ethdev.c:873:
+ if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_10000baseKR_Full_BIT>
#50: FILE: drivers/net/mlx5/mlx5_ethdev.c:874:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_10000baseKR_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_10000baseR_FEC_BIT>
#51: FILE: drivers/net/mlx5/mlx5_ethdev.c:875:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_10000baseR_FEC_BIT)))
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_20000baseMLD2_Full_BIT>
#55: FILE: drivers/net/mlx5/mlx5_ethdev.c:877:
+ if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_20000baseMLD2_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_20000baseKR2_Full_BIT>
#56: FILE: drivers/net/mlx5/mlx5_ethdev.c:878:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_20000baseKR2_Full_BIT)))
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseKR4_Full_BIT>
#62: FILE: drivers/net/mlx5/mlx5_ethdev.c:880:
+ if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_40000baseKR4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseCR4_Full_BIT>
#63: FILE: drivers/net/mlx5/mlx5_ethdev.c:881:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_40000baseCR4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT>
#64: FILE: drivers/net/mlx5/mlx5_ethdev.c:882:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseLR4_Full_BIT>
#65: FILE: drivers/net/mlx5/mlx5_ethdev.c:883:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_40000baseLR4_Full_BIT)))
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseKR4_Full_BIT>
#71: FILE: drivers/net/mlx5/mlx5_ethdev.c:885:
+ if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_56000baseKR4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT>
#72: FILE: drivers/net/mlx5/mlx5_ethdev.c:886:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT>
#73: FILE: drivers/net/mlx5/mlx5_ethdev.c:887:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT>
#74: FILE: drivers/net/mlx5/mlx5_ethdev.c:888:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT)))
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_25000baseCR_Full_BIT>
#79: FILE: drivers/net/mlx5/mlx5_ethdev.c:890:
+ if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_25000baseCR_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_25000baseKR_Full_BIT>
#80: FILE: drivers/net/mlx5/mlx5_ethdev.c:891:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_25000baseKR_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_25000baseSR_Full_BIT>
#81: FILE: drivers/net/mlx5/mlx5_ethdev.c:892:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_25000baseSR_Full_BIT)))
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT>
#85: FILE: drivers/net/mlx5/mlx5_ethdev.c:894:
+ if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT>
#86: FILE: drivers/net/mlx5/mlx5_ethdev.c:895:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT)))
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT>
#92: FILE: drivers/net/mlx5/mlx5_ethdev.c:897:
+ if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT>
#93: FILE: drivers/net/mlx5/mlx5_ethdev.c:898:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT>
#94: FILE: drivers/net/mlx5/mlx5_ethdev.c:899:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT) |
CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT>
#95: FILE: drivers/net/mlx5/mlx5_ethdev.c:900:
+ MLX5_BITSHIFT(ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT)))
total: 0 errors, 0 warnings, 25 checks, 80 lines checked
parent reply other threads:[~2017-11-10 14:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171110141746.19251-1-makarov@kraftway.ru>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110141858.E70A01B6FB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=makarov@kraftway.ru \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).