From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id E0CC31B22C; Wed, 15 Nov 2017 09:18:33 +0100 (CET)
In-Reply-To: <20171115081652.14490-1-hhaim@cisco.com>
References: <20171115081652.14490-1-hhaim@cisco.com>
To: test-report@dpdk.org
Cc: "Hanoch Haim \(hhaim\)" <hhaim@cisco.com>
Message-Id: <20171115081833.E0CC31B22C@dpdk.org>
Date: Wed, 15 Nov 2017 09:18:33 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31375 [PATCH] mbuf: cleanup
	rte_pktmbuf_lastseg() fix atomic usage
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Nov 2017 08:18:34 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31375

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#30: FILE: lib/librte_mbuf/rte_mbuf.h:1165:
+    if (m->next != NULL) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#31: FILE: lib/librte_mbuf/rte_mbuf.h:1166:
+        m->next = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#31: FILE: lib/librte_mbuf/rte_mbuf.h:1166:
+        m->next = NULL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#32: FILE: lib/librte_mbuf/rte_mbuf.h:1167:
+        m->nb_segs = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#32: FILE: lib/librte_mbuf/rte_mbuf.h:1167:
+        m->nb_segs = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#33: FILE: lib/librte_mbuf/rte_mbuf.h:1168:
+    }$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#42: FILE: lib/librte_mbuf/rte_mbuf.h:1334:
 	if (rte_mbuf_refcnt_update(md, -1) == 0) {
+        rte_pktmbuf_reset_before_free(m);

ERROR:CODE_INDENT: code indent should use tabs where possible
#45: FILE: lib/librte_mbuf/rte_mbuf.h:1335:
+        rte_pktmbuf_reset_before_free(m);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#45: FILE: lib/librte_mbuf/rte_mbuf.h:1335:
+        rte_pktmbuf_reset_before_free(m);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#58: FILE: lib/librte_mbuf/rte_mbuf.h:1365:
+        rte_pktmbuf_reset_before_free(m);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#58: FILE: lib/librte_mbuf/rte_mbuf.h:1365:
+        rte_pktmbuf_reset_before_free(m);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#63: FILE: lib/librte_mbuf/rte_mbuf.h:1368:
+       } else if (rte_mbuf_refcnt_update(md, -1) == 0) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 16)
#63: FILE: lib/librte_mbuf/rte_mbuf.h:1368:
+       } else if (rte_mbuf_refcnt_update(md, -1) == 0) {
[...]
 		if (RTE_MBUF_INDIRECT(m))

ERROR:CODE_INDENT: code indent should use tabs where possible
#72: FILE: lib/librte_mbuf/rte_mbuf.h:1373:
+        rte_pktmbuf_reset_before_free(m);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#72: FILE: lib/librte_mbuf/rte_mbuf.h:1373:
+        rte_pktmbuf_reset_before_free(m);$

total: 5 errors, 10 warnings, 52 lines checked