From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw31387 [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg() fix atomic usage
Date: Wed, 15 Nov 2017 18:32:36 +0100 (CET) [thread overview]
Message-ID: <20171115173236.7AE4B1B1EE@dpdk.org> (raw)
In-Reply-To: <20171115173058.mrkrv3usbl5sfw3h@platinum>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31387
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19:
> Ilia, I assume there is a reason why Oliver did that, I just consolidate the code.
ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#44:
It looks it is a regression introduced by commit 8f094a9ac5d7.
ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#146:
--- a/lib/librte_mbuf/rte_mbuf.h
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: lib/librte_mbuf/rte_mbuf.h:1364:
+ } else {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#153: FILE: lib/librte_mbuf/rte_mbuf.h:1364:
+ } else {
[...]
+ ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: lib/librte_mbuf/rte_mbuf.h:1366:
+ /* We don't use rte_mbuf_refcnt_update() because we already$
ERROR:CODE_INDENT: code indent should use tabs where possible
#156: FILE: lib/librte_mbuf/rte_mbuf.h:1367:
+ * tested that refcnt != 1.$
ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: lib/librte_mbuf/rte_mbuf.h:1368:
+ */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: lib/librte_mbuf/rte_mbuf.h:1370:
+ ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: lib/librte_mbuf/rte_mbuf.h:1370:
+ ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: lib/librte_mbuf/rte_mbuf.h:1372:
+ ret = --m->refcnt;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: lib/librte_mbuf/rte_mbuf.h:1372:
+ ret = --m->refcnt;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+ if (ret != 0)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+ if (ret != 0)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#163: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+ if (ret != 0)
+ return NULL;
ERROR:CODE_INDENT: code indent should use tabs where possible
#164: FILE: lib/librte_mbuf/rte_mbuf.h:1375:
+ return NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: lib/librte_mbuf/rte_mbuf.h:1375:
+ return NULL;$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 10 errors, 8 warnings, 26 lines checked
parent reply other threads:[~2017-11-15 17:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171115173058.mrkrv3usbl5sfw3h@platinum>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115173236.7AE4B1B1EE@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).