From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 7AE4B1B1EE; Wed, 15 Nov 2017 18:32:36 +0100 (CET)
In-Reply-To: <20171115173058.mrkrv3usbl5sfw3h@platinum>
References: <20171115173058.mrkrv3usbl5sfw3h@platinum>
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Message-Id: <20171115173236.7AE4B1B1EE@dpdk.org>
Date: Wed, 15 Nov 2017 18:32:36 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31387 [PATCH v3] mbuf: cleanup
	rte_pktmbuf_lastseg() fix atomic usage
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Nov 2017 17:32:36 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31387

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19: 
> Ilia, I assume there is a reason why Oliver did that, I just consolidate the code. 

ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#44: 
It looks it is a regression introduced by commit 8f094a9ac5d7.

ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#146: 
--- a/lib/librte_mbuf/rte_mbuf.h

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: lib/librte_mbuf/rte_mbuf.h:1364:
+       } else {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#153: FILE: lib/librte_mbuf/rte_mbuf.h:1364:
+       } else {
[...]
+               ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);

ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: lib/librte_mbuf/rte_mbuf.h:1366:
+               /* We don't use rte_mbuf_refcnt_update() because we already$

ERROR:CODE_INDENT: code indent should use tabs where possible
#156: FILE: lib/librte_mbuf/rte_mbuf.h:1367:
+                * tested that refcnt != 1.$

ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: lib/librte_mbuf/rte_mbuf.h:1368:
+                */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: lib/librte_mbuf/rte_mbuf.h:1370:
+               ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: lib/librte_mbuf/rte_mbuf.h:1370:
+               ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: lib/librte_mbuf/rte_mbuf.h:1372:
+               ret = --m->refcnt;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: lib/librte_mbuf/rte_mbuf.h:1372:
+               ret = --m->refcnt;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+               if (ret != 0)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+               if (ret != 0)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#163: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+               if (ret != 0)
+                       return NULL;

ERROR:CODE_INDENT: code indent should use tabs where possible
#164: FILE: lib/librte_mbuf/rte_mbuf.h:1375:
+                       return NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: lib/librte_mbuf/rte_mbuf.h:1375:
+                       return NULL;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 10 errors, 8 warnings, 26 lines checked