* [dpdk-test-report] |WARNING| pw31389 [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg() fix atomic usage
[not found] <2fa9a7806c9e447995d6017c6def9894@XCH-RTP-017.cisco.com>
@ 2017-11-16 7:16 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-11-16 7:16 UTC (permalink / raw)
To: test-report; +Cc: Hanoch Haim (hhaim)
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31389
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19:
1) It is not about clear/not-clear, it is error prone to *replicate* code that has the same logic.
ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Hanoch Haim (hhaim)\r'
#53:
To: Hanoch Haim (hhaim)
ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Ilya Matveychikov; dev@dpdk.org; Konstantin Ananyev\r'
#54:
Cc: Ilya Matveychikov; dev@dpdk.org; Konstantin Ananyev
ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#87:
It looks it is a regression introduced by commit 8f094a9ac5d7.
ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#196:
--- a/lib/librte_mbuf/rte_mbuf.h
ERROR:DOS_LINE_ENDINGS: DOS line endings
#203: FILE: lib/librte_mbuf/rte_mbuf.h:1364:
+ } else {^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: lib/librte_mbuf/rte_mbuf.h:1364:
+ } else {^M$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#203: FILE: lib/librte_mbuf/rte_mbuf.h:1364:
+ } else {
[...]
+ ret = rte_atomic16_add_return(&m->refcnt_atomic, -1);
ERROR:TRAILING_WHITESPACE: trailing whitespace
#205: FILE: lib/librte_mbuf/rte_mbuf.h:1366:
+ /* We don't use rte_mbuf_refcnt_update() because we already^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#205: FILE: lib/librte_mbuf/rte_mbuf.h:1366:
+ /* We don't use rte_mbuf_refcnt_update() because we already^M$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#206: FILE: lib/librte_mbuf/rte_mbuf.h:1367:
+ * tested that refcnt != 1.^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#206: FILE: lib/librte_mbuf/rte_mbuf.h:1367:
+ * tested that refcnt != 1.^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#207: FILE: lib/librte_mbuf/rte_mbuf.h:1368:
+ */^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#207: FILE: lib/librte_mbuf/rte_mbuf.h:1368:
+ */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#208: FILE: lib/librte_mbuf/rte_mbuf.h:1369:
+#ifdef RTE_MBUF_REFCNT_ATOMIC^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#209: FILE: lib/librte_mbuf/rte_mbuf.h:1370:
+ ret = rte_atomic16_add_return(&m->refcnt_atomic, -1); ^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#209: FILE: lib/librte_mbuf/rte_mbuf.h:1370:
+ ret = rte_atomic16_add_return(&m->refcnt_atomic, -1); ^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#209: FILE: lib/librte_mbuf/rte_mbuf.h:1370:
+ ret = rte_atomic16_add_return(&m->refcnt_atomic, -1); ^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#210: FILE: lib/librte_mbuf/rte_mbuf.h:1371:
+#else^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#211: FILE: lib/librte_mbuf/rte_mbuf.h:1372:
+ ret = --m->refcnt;^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#211: FILE: lib/librte_mbuf/rte_mbuf.h:1372:
+ ret = --m->refcnt;^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#211: FILE: lib/librte_mbuf/rte_mbuf.h:1372:
+ ret = --m->refcnt;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#212: FILE: lib/librte_mbuf/rte_mbuf.h:1373:
+#endif^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#213: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+ if (ret != 0)^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#213: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+ if (ret != 0)^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#213: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+ if (ret != 0)^M$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#213: FILE: lib/librte_mbuf/rte_mbuf.h:1374:
+ if (ret != 0)
+ return NULL;
ERROR:DOS_LINE_ENDINGS: DOS line endings
#214: FILE: lib/librte_mbuf/rte_mbuf.h:1375:
+ return NULL;^M$
ERROR:CODE_INDENT: code indent should use tabs where possible
#214: FILE: lib/librte_mbuf/rte_mbuf.h:1375:
+ return NULL;^M$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#214: FILE: lib/librte_mbuf/rte_mbuf.h:1375:
+ return NULL;^M$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 23 errors, 8 warnings, 19 lines checked
^ permalink raw reply [flat|nested] only message in thread