From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 23B2C1B2E7; Thu, 16 Nov 2017 09:05:29 +0100 (CET)
In-Reply-To: <1510819481-6809-13-git-send-email-arybchenko@solarflare.com>
References: <1510819481-6809-13-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20171116080529.23B2C1B2E7@dpdk.org>
Date: Thu, 16 Nov 2017 09:05:29 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31400 [PATCH 12/53] net/sfc/base:
	precheck and verify flash writes
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Nov 2017 08:05:29 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31400

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#51: FILE: drivers/net/sfc/base/ef10_impl.h:453:
+extern	__checkReturn		efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#178: FILE: drivers/net/sfc/base/efx_nvram.c:313:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#183: FILE: drivers/net/sfc/base/efx_nvram.c:318:
+	if ((rc = envop->envo_partn_read_backup(enp, partn, offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#187: FILE: drivers/net/sfc/base/efx_nvram.c:322:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#194: FILE: drivers/net/sfc/base/efx_nvram.c:329:
+	return (rc);

total: 4 errors, 0 warnings, 1 checks, 137 lines checked