automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw31401 [PATCH 06/53] net/sfc/base: extend NVRAM RW finish to return verify result
Date: Thu, 16 Nov 2017 09:05:30 +0100 (CET)	[thread overview]
Message-ID: <20171116080530.3F55A1B2E9@dpdk.org> (raw)
In-Reply-To: <1510819481-6809-7-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31401

_coding style issues_


CHECK:SPACING: No space is necessary after a cast
#50: FILE: drivers/net/sfc/base/efx_bootcfg.c:348:
+		(void) efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG, NULL);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#55: FILE: drivers/net/sfc/base/efx_bootcfg.c:352:
+	if ((rc = efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG, NULL)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#64: FILE: drivers/net/sfc/base/efx_bootcfg.c:524:
+	if ((rc = efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG, NULL)) != 0)

CHECK:SPACING: No space is necessary after a cast
#73: FILE: drivers/net/sfc/base/efx_bootcfg.c:540:
+	(void) efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG, NULL);

total: 2 errors, 0 warnings, 2 checks, 71 lines checked

           reply	other threads:[~2017-11-16  8:05 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1510819481-6809-7-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116080530.3F55A1B2E9@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).