From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw31413 [PATCH 31/53] net/sfc/base: improve names for EVQ descriptor counts
Date: Thu, 16 Nov 2017 09:10:41 +0100 (CET) [thread overview]
Message-ID: <20171116081041.15B8A1B245@dpdk.org> (raw)
In-Reply-To: <1510819481-6809-32-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31413
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs < EFX_EVQ_MINNEVS'
#44: FILE: drivers/net/sfc/base/ef10_ev.c:480:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs > EFX_EVQ_MAXNEVS'
#44: FILE: drivers/net/sfc/base/ef10_ev.c:480:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#130: FILE: drivers/net/sfc/base/efx_ev.c:274:
+ if ((rc = eevop->eevo_qcreate(enp, index, esmp, ndescs, id, us, flags,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs < EFX_EVQ_MINNEVS'
#148: FILE: drivers/net/sfc/base/efx_ev.c:1301:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs > EFX_EVQ_MAXNEVS'
#148: FILE: drivers/net/sfc/base/efx_ev.c:1301:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {
total: 1 errors, 0 warnings, 4 checks, 107 lines checked
parent reply other threads:[~2017-11-16 8:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1510819481-6809-32-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116081041.15B8A1B245@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).