From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 15B8A1B245; Thu, 16 Nov 2017 09:10:41 +0100 (CET)
In-Reply-To: <1510819481-6809-32-git-send-email-arybchenko@solarflare.com>
References: <1510819481-6809-32-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20171116081041.15B8A1B245@dpdk.org>
Date: Thu, 16 Nov 2017 09:10:41 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31413 [PATCH 31/53] net/sfc/base:
	improve names for EVQ descriptor counts
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Nov 2017 08:10:41 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31413

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs < EFX_EVQ_MINNEVS'
#44: FILE: drivers/net/sfc/base/ef10_ev.c:480:
+	if (!ISP2(ndescs) ||
+	    (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs > EFX_EVQ_MAXNEVS'
#44: FILE: drivers/net/sfc/base/ef10_ev.c:480:
+	if (!ISP2(ndescs) ||
+	    (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#130: FILE: drivers/net/sfc/base/efx_ev.c:274:
+	if ((rc = eevop->eevo_qcreate(enp, index, esmp, ndescs, id, us, flags,

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs < EFX_EVQ_MINNEVS'
#148: FILE: drivers/net/sfc/base/efx_ev.c:1301:
+	if (!ISP2(ndescs) ||
+	    (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs > EFX_EVQ_MAXNEVS'
#148: FILE: drivers/net/sfc/base/efx_ev.c:1301:
+	if (!ISP2(ndescs) ||
+	    (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {

total: 1 errors, 0 warnings, 4 checks, 107 lines checked