* [dpdk-test-report] |WARNING| pw31413 [PATCH 31/53] net/sfc/base: improve names for EVQ descriptor counts
[not found] <1510819481-6809-32-git-send-email-arybchenko@solarflare.com>
@ 2017-11-16 8:10 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-11-16 8:10 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31413
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs < EFX_EVQ_MINNEVS'
#44: FILE: drivers/net/sfc/base/ef10_ev.c:480:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs > EFX_EVQ_MAXNEVS'
#44: FILE: drivers/net/sfc/base/ef10_ev.c:480:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#130: FILE: drivers/net/sfc/base/efx_ev.c:274:
+ if ((rc = eevop->eevo_qcreate(enp, index, esmp, ndescs, id, us, flags,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs < EFX_EVQ_MINNEVS'
#148: FILE: drivers/net/sfc/base/efx_ev.c:1301:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs > EFX_EVQ_MAXNEVS'
#148: FILE: drivers/net/sfc/base/efx_ev.c:1301:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_EVQ_MINNEVS) || (ndescs > EFX_EVQ_MAXNEVS)) {
total: 1 errors, 0 warnings, 4 checks, 107 lines checked
^ permalink raw reply [flat|nested] only message in thread