From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 0D8E81B2A5; Thu, 16 Nov 2017 09:12:27 +0100 (CET)
In-Reply-To: <1510819481-6809-42-git-send-email-arybchenko@solarflare.com>
References: <1510819481-6809-42-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20171116081227.0D8E81B2A5@dpdk.org>
Date: Thu, 16 Nov 2017 09:12:27 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31422 [PATCH 41/53] net/sfc/base:
	fix diagnostics support build without Siena
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Nov 2017 08:12:27 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31422

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#303: FILE: drivers/net/sfc/base/siena_nic.c:553:
+			if (memcmp(&reg, &buf, sizeof (reg))) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#318: FILE: drivers/net/sfc/base/siena_nic.c:568:
+			if (memcmp(&reg, &buf, sizeof (reg))) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#342: FILE: drivers/net/sfc/base/siena_nic.c:592:
+	return (rc);

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#345: FILE: drivers/net/sfc/base/siena_nic.c:595:
+	__checkReturn	efx_rc_t

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#381: FILE: drivers/net/sfc/base/siena_nic.c:631:
+			if (memcmp(&reg, &buf, sizeof (reg))) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#398: FILE: drivers/net/sfc/base/siena_nic.c:648:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#416: FILE: drivers/net/sfc/base/siena_nic.c:690:
+	if ((rc = siena_nic_test_registers(enp, __siena_registers,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#421: FILE: drivers/net/sfc/base/siena_nic.c:694:
+	if ((rc = siena_nic_test_tables(enp, __siena_tables,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#427: FILE: drivers/net/sfc/base/siena_nic.c:699:
+	if ((rc = siena_nic_test_tables(enp, __siena_tables,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#433: FILE: drivers/net/sfc/base/siena_nic.c:704:
+	if ((rc = siena_nic_test_tables(enp, __siena_tables,

total: 6 errors, 3 warnings, 1 checks, 372 lines checked