* [dpdk-test-report] |WARNING| pw31426 [PATCH 33/53] net/sfc/base: improve names for TXQ descriptor counts
[not found] <1510819481-6809-34-git-send-email-arybchenko@solarflare.com>
@ 2017-11-16 8:14 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-11-16 8:14 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31426
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#44: FILE: drivers/net/sfc/base/ef10_impl.h:682:
+extern __checkReturn efx_rc_t
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#105: FILE: drivers/net/sfc/base/ef10_tx.c:215:
+ if ((rc = efx_mcdi_init_txq(enp, ndescs, eep->ee_index, label, index,
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#247: FILE: drivers/net/sfc/base/efx_tx.c:98:
+ __checkReturn efx_rc_t
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#314: FILE: drivers/net/sfc/base/efx_tx.c:376:
+ if ((rc = etxop->etxo_qpost(etp, eb, ndescs, completed, addedp)) != 0)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs < EFX_TXQ_MINNDESCS'
#392: FILE: drivers/net/sfc/base/efx_tx.c:913:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_TXQ_MINNDESCS) || (ndescs > EFX_EVQ_MAXNEVS)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ndescs > EFX_EVQ_MAXNEVS'
#392: FILE: drivers/net/sfc/base/efx_tx.c:913:
+ if (!ISP2(ndescs) ||
+ (ndescs < EFX_TXQ_MINNDESCS) || (ndescs > EFX_EVQ_MAXNEVS)) {
total: 2 errors, 1 warnings, 3 checks, 380 lines checked
^ permalink raw reply [flat|nested] only message in thread