From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: jerry.lilijun@huawei.com
Subject: [dpdk-test-report] |WARNING| pw31477 [PATCH] net/bonding: fix bond 8023ad mode enable using wrong index
Date: Mon, 20 Nov 2017 08:16:10 +0100 (CET) [thread overview]
Message-ID: <20171120071610.7445B1B18C@dpdk.org> (raw)
In-Reply-To: <40280F65B1B0B44E8089ED31C01616EBA357ADA1@dggeml509-mbx.china.huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31477
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17:
In the function bond_mode_8023ad_enable(), the var i is to used to as the second parameter to pass the slave dev's dpdk port id to the function bond_mode_8023ad_activate_slave().
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#31: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1161:
for (i = 0; i < internals->active_slave_count; i++)
+ bond_mode_8023ad_activate_slave(bond_dev, internals->active_slaves[i]);
ERROR:CODE_INDENT: code indent should use tabs where possible
#33: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1162:
+ bond_mode_8023ad_activate_slave(bond_dev, internals->active_slaves[i]);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#33: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1162:
+ bond_mode_8023ad_activate_slave(bond_dev, internals->active_slaves[i]);$
ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#36: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1164:
}
total: 2 errors, 3 warnings, 0 checks, 8 lines checked
parent reply other threads:[~2017-11-20 7:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <40280F65B1B0B44E8089ED31C01616EBA357ADA1@dggeml509-mbx.china.huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120071610.7445B1B18C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jerry.lilijun@huawei.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).