From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 7445B1B18C; Mon, 20 Nov 2017 08:16:10 +0100 (CET)
In-Reply-To: <40280F65B1B0B44E8089ED31C01616EBA357ADA1@dggeml509-mbx.china.huawei.com>
References: <40280F65B1B0B44E8089ED31C01616EBA357ADA1@dggeml509-mbx.china.huawei.com>
To: test-report@dpdk.org
Cc: jerry.lilijun@huawei.com
Message-Id: <20171120071610.7445B1B18C@dpdk.org>
Date: Mon, 20 Nov 2017 08:16:10 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31477 [PATCH] net/bonding: fix bond
	8023ad mode enable using wrong index
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Nov 2017 07:16:10 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31477

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
In the function bond_mode_8023ad_enable(), the var i is to used to as the second parameter to pass the slave dev's dpdk port id to the function bond_mode_8023ad_activate_slave(). 

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#31: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1161:
        for (i = 0; i < internals->active_slave_count; i++)
+               bond_mode_8023ad_activate_slave(bond_dev, internals->active_slaves[i]);

ERROR:CODE_INDENT: code indent should use tabs where possible
#33: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1162:
+               bond_mode_8023ad_activate_slave(bond_dev, internals->active_slaves[i]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#33: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1162:
+               bond_mode_8023ad_activate_slave(bond_dev, internals->active_slaves[i]);$

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#36: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1164:
}

total: 2 errors, 3 warnings, 0 checks, 8 lines checked