From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Erik Carrillo <erik.g.carrillo@intel.com>
Subject: [dpdk-test-report] |WARNING| pw31489 [PATCH RFC v3 1/1] eventtimer: introduce event timer adapter
Date: Mon, 20 Nov 2017 23:35:44 +0100 (CET) [thread overview]
Message-ID: <20171120223544.9BE6A7CEF@dpdk.org> (raw)
In-Reply-To: <1511217333-142455-2-git-send-email-erik.g.carrillo@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31489
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#181: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:51:
+extern const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops;
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#189: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:59:
+#define ADAPTER_VALID_OR_ERR_RET(adapter, retval) do { \
+ if (!adapter_valid(adapter)) \
+ return retval; \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#194: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:64:
+#define FUNC_PTR_OR_ERR_RET(func, errval) do { \
+ if ((func) == NULL) \
+ return errval; \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#199: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:69:
+#define FUNC_PTR_OR_NULL_RET_WITH_ERRNO(func, errval) do { \
+ if ((func) == NULL) { \
+ rte_errno = errval; \
+ return NULL; \
+ } \
+} while (0)
total: 0 errors, 4 warnings, 1497 lines checked
parent reply other threads:[~2017-11-20 22:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1511217333-142455-2-git-send-email-erik.g.carrillo@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120223544.9BE6A7CEF@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).