From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 9BE6A7CEF; Mon, 20 Nov 2017 23:35:44 +0100 (CET)
In-Reply-To: <1511217333-142455-2-git-send-email-erik.g.carrillo@intel.com>
References: <1511217333-142455-2-git-send-email-erik.g.carrillo@intel.com>
To: test-report@dpdk.org
Cc: Erik Carrillo <erik.g.carrillo@intel.com>
Message-Id: <20171120223544.9BE6A7CEF@dpdk.org>
Date: Mon, 20 Nov 2017 23:35:44 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31489 [PATCH RFC v3 1/1] eventtimer:
	introduce event timer adapter
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Nov 2017 22:35:44 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31489

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#181: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:51:
+extern const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops;

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#189: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:59:
+#define ADAPTER_VALID_OR_ERR_RET(adapter, retval) do { \
+	if (!adapter_valid(adapter))		       \
+		return retval;			       \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#194: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:64:
+#define FUNC_PTR_OR_ERR_RET(func, errval) do { \
+	if ((func) == NULL)		       \
+		return errval;		       \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#199: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:69:
+#define FUNC_PTR_OR_NULL_RET_WITH_ERRNO(func, errval) do { \
+	if ((func) == NULL) {				   \
+		rte_errno = errval;			   \
+		return NULL;				   \
+	}						   \
+} while (0)

total: 0 errors, 4 warnings, 1497 lines checked