From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id DF0A52BD0; Thu, 23 Nov 2017 13:03:44 +0100 (CET)
In-Reply-To: <20171123120252.143695-3-shahafs@mellanox.com>
References: <20171123120252.143695-3-shahafs@mellanox.com>
To: test-report@dpdk.org
Cc: Shahaf Shuler <shahafs@mellanox.com>
Message-Id: <20171123120344.DF0A52BD0@dpdk.org>
Date: Thu, 23 Nov 2017 13:03:44 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31536 [PATCH 2/6] net/mlx5: convert
	to new Tx offloads API
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Nov 2017 12:03:45 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31536

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#195: FILE: drivers/net/mlx5/mlx5.h:189:
+void mlx5_args_update(struct priv *);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#215: FILE: drivers/net/mlx5/mlx5_ethdev.c:588:
+		return ENOTSUP;

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#268: FILE: drivers/net/mlx5/mlx5_rxtx.h:295:
+uint64_t mlx5_priv_get_tx_port_offloads(struct priv *);

total: 0 errors, 3 warnings, 0 checks, 370 lines checked