From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shachar Beiser <shacharbe@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw31555 [PATCH v1 2/2] net/mlx4: load libmlx4 and libibverbs in run-time
Date: Thu, 23 Nov 2017 13:19:04 +0100 (CET) [thread overview]
Message-ID: <20171123121904.438272BDF@dpdk.org> (raw)
In-Reply-To: <03ced6a62d55d902be841c31ffc4477977c099c7.1511439468.git.shacharbe@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31555
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: drivers/net/mlx4/lib/mlx4_dll.c:54:
+ void *dlhandle;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#152: FILE: drivers/net/mlx4/lib/mlx4_dll.c:55:
+ int ret;$
WARNING:TYPO_SPELLING: 'libary' may be misspelled - perhaps 'library'?
#215: FILE: drivers/net/mlx4/lib/mlx4_dll.c:118:
+ /* Otherwise use the system libary search path. This is the historical
WARNING:LONG_LINE: line over 90 characters
#304: FILE: drivers/net/mlx4/lib/mlx4_dll.c:207:
+ dlsym(handle, "ibv_free_device_list");
WARNING:LONG_LINE: line over 90 characters
#508: FILE: drivers/net/mlx4/lib/mlx4_dll.c:411:
+ enum mlx4dv_set_ctx_attr_type type,
WARNING:LONG_LINE: line over 90 characters
#677: FILE: drivers/net/mlx4/lib/mlx4_dll.c:580:
+ struct ibv_context *context)
WARNING:LONG_LINE: line over 90 characters
#723: FILE: drivers/net/mlx4/lib/mlx4_dll.c:626:
+ struct ibv_qp_init_attr *qp_init_attr)
WARNING:LONG_LINE: line over 90 characters
#886: FILE: drivers/net/mlx4/lib/mlx4_dll.h:52:
+ struct ibv_device_attr *device_attr);
WARNING:SPACING: missing space after return type
#897: FILE: drivers/net/mlx4/lib/mlx4_dll.h:63:
+ int(*ibv_get_cq_event)(struct ibv_comp_channel *channel,
WARNING:LONG_LINE: line over 90 characters
#901: FILE: drivers/net/mlx4/lib/mlx4_dll.h:67:
+ struct ibv_qp_init_attr *qp_init_attr);
WARNING:LONG_LINE: line over 90 characters
#909: FILE: drivers/net/mlx4/lib/mlx4_dll.h:75:
+ int cqe, void *cq_context,
WARNING:LONG_LINE: line over 90 characters
#910: FILE: drivers/net/mlx4/lib/mlx4_dll.h:76:
+ struct ibv_comp_channel *channel,
ERROR:SPACING: space required after that close brace '}'
#916: FILE: drivers/net/mlx4/lib/mlx4_dll.h:82:
+}mlx4_libverbs;
WARNING:LONG_LINE: line over 90 characters
#923: FILE: drivers/net/mlx4/lib/mlx4_dll.h:89:
+ struct mlx4dv_context *attrs_out);
WARNING:LONG_LINE: line over 90 characters
#925: FILE: drivers/net/mlx4/lib/mlx4_dll.h:91:
+ enum mlx4dv_set_ctx_attr_type type,
ERROR:SPACING: space required after that close brace '}'
#927: FILE: drivers/net/mlx4/lib/mlx4_dll.h:93:
+}mlx4_lmlx4;
ERROR:SPACING: space prohibited after that open parenthesis '('
#955: FILE: drivers/net/mlx4/mlx4.c:726:
+ if ( ret != 0 )
ERROR:SPACING: space prohibited before that close parenthesis ')'
#955: FILE: drivers/net/mlx4/mlx4.c:726:
+ if ( ret != 0 )
total: 4 errors, 14 warnings, 1013 lines checked
parent reply other threads:[~2017-11-23 12:19 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <03ced6a62d55d902be841c31ffc4477977c099c7.1511439468.git.shacharbe@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123121904.438272BDF@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=shacharbe@mellanox.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).