From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 438272BDF; Thu, 23 Nov 2017 13:19:04 +0100 (CET)
In-Reply-To: <03ced6a62d55d902be841c31ffc4477977c099c7.1511439468.git.shacharbe@mellanox.com>
References: <03ced6a62d55d902be841c31ffc4477977c099c7.1511439468.git.shacharbe@mellanox.com>
To: test-report@dpdk.org
Cc: Shachar Beiser <shacharbe@mellanox.com>
Message-Id: <20171123121904.438272BDF@dpdk.org>
Date: Thu, 23 Nov 2017 13:19:04 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31555 [PATCH v1 2/2] net/mlx4: load
	libmlx4 and libibverbs in run-time
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Nov 2017 12:19:04 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31555

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: drivers/net/mlx4/lib/mlx4_dll.c:54:
+    void *dlhandle;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#152: FILE: drivers/net/mlx4/lib/mlx4_dll.c:55:
+    int ret;$

WARNING:TYPO_SPELLING: 'libary' may be misspelled - perhaps 'library'?
#215: FILE: drivers/net/mlx4/lib/mlx4_dll.c:118:
+	/* Otherwise use the system libary search path. This is the historical

WARNING:LONG_LINE: line over 90 characters
#304: FILE: drivers/net/mlx4/lib/mlx4_dll.c:207:
+										dlsym(handle, "ibv_free_device_list");

WARNING:LONG_LINE: line over 90 characters
#508: FILE: drivers/net/mlx4/lib/mlx4_dll.c:411:
+							enum mlx4dv_set_ctx_attr_type type,

WARNING:LONG_LINE: line over 90 characters
#677: FILE: drivers/net/mlx4/lib/mlx4_dll.c:580:
+											  struct ibv_context *context)

WARNING:LONG_LINE: line over 90 characters
#723: FILE: drivers/net/mlx4/lib/mlx4_dll.c:626:
+							 struct ibv_qp_init_attr *qp_init_attr)

WARNING:LONG_LINE: line over 90 characters
#886: FILE: drivers/net/mlx4/lib/mlx4_dll.h:52:
+							struct ibv_device_attr *device_attr);

WARNING:SPACING: missing space after return type
#897: FILE: drivers/net/mlx4/lib/mlx4_dll.h:63:
+	int(*ibv_get_cq_event)(struct ibv_comp_channel *channel,

WARNING:LONG_LINE: line over 90 characters
#901: FILE: drivers/net/mlx4/lib/mlx4_dll.h:67:
+									struct ibv_qp_init_attr *qp_init_attr);

WARNING:LONG_LINE: line over 90 characters
#909: FILE: drivers/net/mlx4/lib/mlx4_dll.h:75:
+									int cqe, void *cq_context,

WARNING:LONG_LINE: line over 90 characters
#910: FILE: drivers/net/mlx4/lib/mlx4_dll.h:76:
+									struct ibv_comp_channel *channel,

ERROR:SPACING: space required after that close brace '}'
#916: FILE: drivers/net/mlx4/lib/mlx4_dll.h:82:
+}mlx4_libverbs;

WARNING:LONG_LINE: line over 90 characters
#923: FILE: drivers/net/mlx4/lib/mlx4_dll.h:89:
+							   struct mlx4dv_context *attrs_out);

WARNING:LONG_LINE: line over 90 characters
#925: FILE: drivers/net/mlx4/lib/mlx4_dll.h:91:
+								enum mlx4dv_set_ctx_attr_type type,

ERROR:SPACING: space required after that close brace '}'
#927: FILE: drivers/net/mlx4/lib/mlx4_dll.h:93:
+}mlx4_lmlx4;

ERROR:SPACING: space prohibited after that open parenthesis '('
#955: FILE: drivers/net/mlx4/mlx4.c:726:
+	if ( ret != 0 )

ERROR:SPACING: space prohibited before that close parenthesis ')'
#955: FILE: drivers/net/mlx4/mlx4.c:726:
+	if ( ret != 0 )

total: 4 errors, 14 warnings, 1013 lines checked