automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shachar Beiser <shacharbe@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw31556 [PATCH v1 1/2] net/mlx5: load libmlx5 and libibverbs in run-time
Date: Thu, 23 Nov 2017 13:19:07 +0100 (CET)	[thread overview]
Message-ID: <20171123121907.7BF062BDF@dpdk.org> (raw)
In-Reply-To: <5265eb77c39dfbb097042c9d89608a6f55e47148.1511439468.git.shacharbe@mellanox.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31556

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: drivers/net/mlx5/lib/mlx5_dll.c:54:
+    void *dlhandle;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: drivers/net/mlx5/lib/mlx5_dll.c:55:
+    int ret;$

WARNING:TYPO_SPELLING: 'libary' may be misspelled - perhaps 'library'?
#262: FILE: drivers/net/mlx5/lib/mlx5_dll.c:118:
+	/* Otherwise use the system libary search path. This is the historical

WARNING:LONG_LINE: line over 90 characters
#351: FILE: drivers/net/mlx5/lib/mlx5_dll.c:207:
+										dlsym(handle, "ibv_free_device_list");

WARNING:LONG_LINE: line over 90 characters
#535: FILE: drivers/net/mlx5/lib/mlx5_dll.c:391:
+								   struct ibv_cq_init_attr_ex *cq_attr,

WARNING:LONG_LINE: line over 90 characters
#536: FILE: drivers/net/mlx5/lib/mlx5_dll.c:392:
+								   struct mlx5dv_cq_init_attr *mlx5_cq_attr)

WARNING:LONG_LINE: line over 90 characters
#582: FILE: drivers/net/mlx5/lib/mlx5_dll.c:438:
+							enum mlx5dv_set_ctx_attr_type type,

WARNING:LONG_LINE: line over 90 characters
#751: FILE: drivers/net/mlx5/lib/mlx5_dll.c:607:
+											  struct ibv_context *context)

WARNING:LONG_LINE: line over 90 characters
#797: FILE: drivers/net/mlx5/lib/mlx5_dll.c:653:
+							 struct ibv_qp_init_attr *qp_init_attr)

WARNING:LONG_LINE: line over 90 characters
#960: FILE: drivers/net/mlx5/lib/mlx5_dll.h:52:
+							struct ibv_device_attr *device_attr);

WARNING:SPACING: missing space after return type
#971: FILE: drivers/net/mlx5/lib/mlx5_dll.h:63:
+	int(*ibv_get_cq_event)(struct ibv_comp_channel *channel,

WARNING:LONG_LINE: line over 90 characters
#975: FILE: drivers/net/mlx5/lib/mlx5_dll.h:67:
+									struct ibv_qp_init_attr *qp_init_attr);

WARNING:LONG_LINE: line over 90 characters
#983: FILE: drivers/net/mlx5/lib/mlx5_dll.h:75:
+									int cqe, void *cq_context,

WARNING:LONG_LINE: line over 90 characters
#984: FILE: drivers/net/mlx5/lib/mlx5_dll.h:76:
+									struct ibv_comp_channel *channel,

ERROR:SPACING: space required after that close brace '}'
#990: FILE: drivers/net/mlx5/lib/mlx5_dll.h:82:
+}mlx5_libverbs;

WARNING:LONG_LINE: line over 90 characters
#996: FILE: drivers/net/mlx5/lib/mlx5_dll.h:88:
+								struct ibv_cq_init_attr_ex *cq_attr,

WARNING:LONG_LINE: line over 90 characters
#997: FILE: drivers/net/mlx5/lib/mlx5_dll.h:89:
+								struct mlx5dv_cq_init_attr *mlx5_cq_attr);

WARNING:LONG_LINE: line over 90 characters
#1000: FILE: drivers/net/mlx5/lib/mlx5_dll.h:92:
+							   struct mlx5dv_context *attrs_out);

WARNING:LONG_LINE: line over 90 characters
#1002: FILE: drivers/net/mlx5/lib/mlx5_dll.h:94:
+								enum mlx5dv_set_ctx_attr_type type,

ERROR:SPACING: space required after that close brace '}'
#1004: FILE: drivers/net/mlx5/lib/mlx5_dll.h:96:
+}mlx5_lmlx5;

ERROR:SPACING: space prohibited after that open parenthesis '('
#1055: FILE: drivers/net/mlx5/mlx5.c:1053:
+	if ( ret != 0 )

ERROR:SPACING: space prohibited before that close parenthesis ')'
#1055: FILE: drivers/net/mlx5/mlx5.c:1053:
+	if ( ret != 0 )

total: 4 errors, 18 warnings, 1135 lines checked

           reply	other threads:[~2017-11-23 12:19 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <5265eb77c39dfbb097042c9d89608a6f55e47148.1511439468.git.shacharbe@mellanox.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171123121907.7BF062BDF@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=shacharbe@mellanox.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).