automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Xiao Wang <xiao.w.wang@intel.com>
Subject: [dpdk-test-report] |WARNING| pw31612 [PATCH 1/2] net/virtio: make control queue thread-safe
Date: Mon, 27 Nov 2017 12:24:29 +0100 (CET)	[thread overview]
Message-ID: <20171127112429.3E2232B99@dpdk.org> (raw)
In-Reply-To: <1511521440-57724-2-git-send-email-xiao.w.wang@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31612

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pkt_num < 1'
#45: FILE: drivers/net/virtio/virtio_ethdev.c:189:
+	if ((vq->vq_free_cnt < ((uint32_t)pkt_num + 2)) || (pkt_num < 1)) {

WARNING:LONG_LINE_COMMENT: line over 90 characters
#80: FILE: drivers/net/virtio/virtio_rxtx.h:87:
+	rte_spinlock_t sl;				/**< spinlock for control queue. */

total: 0 errors, 1 warnings, 1 checks, 40 lines checked

           reply	other threads:[~2017-11-27 11:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1511521440-57724-2-git-send-email-xiao.w.wang@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127112429.3E2232B99@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).