* [dpdk-test-report] |WARNING| pw31618 [PATCH v2 02/14] net/avf: initilization of avf PMD
[not found] <1511505206-97333-3-git-send-email-jingjing.wu@intel.com>
@ 2017-11-27 11:24 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-11-27 11:24 UTC (permalink / raw)
To: test-report; +Cc: Jingjing Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31618
_coding style issues_
WARNING:TYPO_SPELLING: 'initilization' may be misspelled - perhaps 'initialization'?
#5:
Subject: [dpdk-dev] [PATCH v2 02/14] net/avf: initilization of avf PMD
WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#600: FILE: drivers/net/avf/avf_ethdev.c:250:
+ hw->back = AVF_DEV_PRIVATE_TO_ADAPTER(eth_dev->data->dev_private);;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#744: FILE: drivers/net/avf/avf_ethdev.c:394:
+ snprintf(z_name, sizeof(z_name), "avf_dma_%"PRIu64, rte_rand());
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#744: FILE: drivers/net/avf/avf_ethdev.c:394:
+ snprintf(z_name, sizeof(z_name), "avf_dma_%"PRIu64, rte_rand());
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#755: FILE: drivers/net/avf/avf_ethdev.c:405:
+ "memzone %s allocated with physical address: %"PRIu64,
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#769: FILE: drivers/net/avf/avf_ethdev.c:419:
+ "memzone %s to be freed with physical address: %"PRIu64,
WARNING:RETURN_VOID: void function return statements are not generally useful
#832: FILE: drivers/net/avf/avf_ethdev.c:482:
+ return;
+}
CHECK:BRACES: Unbalanced braces around else statement
#1061: FILE: drivers/net/avf/avf_vchnl.c:210:
+ } else
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START'
#1112: FILE: drivers/net/avf/avf_vchnl.c:261:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+ ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+ (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START'
#1112: FILE: drivers/net/avf/avf_vchnl.c:261:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+ ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+ (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START'
#1112: FILE: drivers/net/avf/avf_vchnl.c:261:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+ ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+ (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1149: FILE: drivers/net/avf/avf_vchnl.c:298:
+ /* TODO: basic offload capabilities, need to
+ * add advanced/optional offload capabilities
total: 0 errors, 4 warnings, 1127 lines checked
^ permalink raw reply [flat|nested] only message in thread