From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw31627 [PATCH v2 12/14] net/avf: enable sse vector Rx Tx func
Date: Mon, 27 Nov 2017 12:24:57 +0100 (CET) [thread overview]
Message-ID: <20171127112457.88FF22B99@dpdk.org> (raw)
In-Reply-To: <1511505206-97333-13-git-send-email-jingjing.wu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31627
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->rs_thresh >= AVF_VPMD_TX_MAX_BURST'
#116: FILE: drivers/net/avf/avf_rxtx.c:143:
+ if (((txq->txq_flags & AVF_SIMPLE_FLAGS) == AVF_SIMPLE_FLAGS) &&
+ (txq->rs_thresh >= AVF_VPMD_TX_MAX_BURST) &&
+ (txq->rs_thresh <= AVF_VPMD_TX_MAX_FREE_BUF)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->rs_thresh <= AVF_VPMD_TX_MAX_FREE_BUF'
#116: FILE: drivers/net/avf/avf_rxtx.c:143:
+ if (((txq->txq_flags & AVF_SIMPLE_FLAGS) == AVF_SIMPLE_FLAGS) &&
+ (txq->rs_thresh >= AVF_VPMD_TX_MAX_BURST) &&
+ (txq->rs_thresh <= AVF_VPMD_TX_MAX_FREE_BUF)) {
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#341: FILE: drivers/net/avf/avf_rxtx.c:1659:
+avf_recv_pkts_vec(void __rte_unused *rx_queue,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#342: FILE: drivers/net/avf/avf_rxtx.c:1660:
+ struct rte_mbuf __rte_unused **rx_pkts,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#349: FILE: drivers/net/avf/avf_rxtx.c:1667:
+avf_recv_scattered_pkts_vec(void __rte_unused *rx_queue,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#350: FILE: drivers/net/avf/avf_rxtx.c:1668:
+ struct rte_mbuf __rte_unused **rx_pkts,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#358: FILE: drivers/net/avf/avf_rxtx.c:1676:
+ struct rte_mbuf __rte_unused **tx_pkts,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#364: FILE: drivers/net/avf/avf_rxtx.c:1682:
+avf_rxq_vec_setup(struct avf_rx_queue __rte_unused *rxq)
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#370: FILE: drivers/net/avf/avf_rxtx.c:1688:
+avf_txq_vec_setup(struct avf_tx_queue __rte_unused *txq)
^
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#509: FILE: drivers/net/avf/avf_rxtx_vec_common.h:50:
+ unsigned pkt_idx, buf_idx;
CHECK:BRACES: braces {} should be used on all arms of this statement
#527: FILE: drivers/net/avf/avf_rxtx_vec_common.h:68:
+ if (end->data_len > rxq->crc_len)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#529: FILE: drivers/net/avf/avf_rxtx_vec_common.h:70:
+ else {
CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#542: FILE: drivers/net/avf/avf_rxtx_vec_common.h:83:
+ start = end = NULL;
CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#551: FILE: drivers/net/avf/avf_rxtx_vec_common.h:92:
+ end = start = rx_bufs[buf_idx];
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#634: FILE: drivers/net/avf/avf_rxtx_vec_common.h:175:
+ const unsigned mask = rxq->nb_rx_desc - 1;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#635: FILE: drivers/net/avf/avf_rxtx_vec_common.h:176:
+ unsigned i;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#664: FILE: drivers/net/avf/avf_rxtx_vec_common.h:205:
+ unsigned i;
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#1185: FILE: drivers/net/avf/avf_rxtx_vec_sse.c:482:
+ _mm_storeu_si128((void *)&rx_pkts[pos+1]->rx_descriptor_fields1,
^
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1245: FILE: drivers/net/avf/avf_rxtx_vec_sse.c:542:
+ unsigned i = 0;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1273: FILE: drivers/net/avf/avf_rxtx_vec_sse.c:570:
+ uint16_t nb_pkts, uint64_t flags)$
CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1299: FILE: drivers/net/avf/avf_rxtx_vec_sse.c:596:
+ nb_commit = nb_pkts = (uint16_t)RTE_MIN(txq->nb_free, nb_pkts);
total: 0 errors, 6 warnings, 15 checks, 1295 lines checked
parent reply other threads:[~2017-11-27 11:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1511505206-97333-13-git-send-email-jingjing.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127112457.88FF22B99@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).