[dpdk-test-report] |WARNING| pw31653 [PATCH RFC v2] lib: add compressdev API

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Fiona Trahe <fiona.trahe@intel.com>
Subject: [dpdk-test-report] |WARNING| pw31653 [PATCH RFC v2] lib: add compressdev API
Date: Mon, 27 Nov 2017 12:25:39 +0100 (CET)	[thread overview]
Message-ID: <20171127112539.38EC72C55@dpdk.org> (raw)
In-Reply-To: <1511542566-10455-1-git-send-email-fiona.trahe@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31653

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#67: FILE: lib/Makefile:57:
+DEPDIRS-librte_compressdev += librte_kvargs $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#223: FILE: lib/librte_compressdev/rte_comp.h:87:
+^I/**< DEFLATE compression algorithm $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#233: FILE: lib/librte_compressdev/rte_comp.h:97:
+/**< Compression Level. $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#238: FILE: lib/librte_compressdev/rte_comp.h:102:
+#define^IRTE_COMP_LEVEL_PMD_DEFAULT^I(-1)                                                $

WARNING:LONG_LINE: line over 90 characters
#238: FILE: lib/librte_compressdev/rte_comp.h:102:
+#define	RTE_COMP_LEVEL_PMD_DEFAULT	(-1)                                                

ERROR:TRAILING_WHITESPACE: trailing whitespace
#240: FILE: lib/librte_compressdev/rte_comp.h:104:
+#define^IRTE_COMP_LEVEL_NONE^I^I(0)    $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#261: FILE: lib/librte_compressdev/rte_comp.h:125:
+/* $

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#262: FILE: lib/librte_compressdev/rte_comp.h:126:
+/* 
+enum rte_comp_hash_algo {

ERROR:TRAILING_WHITESPACE: trailing whitespace
#268: FILE: lib/librte_compressdev/rte_comp.h:132:
+xform will need a flag with above enum value $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#404: FILE: lib/librte_compressdev/rte_comp.h:268:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#417: FILE: lib/librte_compressdev/rte_comp.h:281:
+^I/**< destination mbuf $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#479: FILE: lib/librte_compressdev/rte_comp.h:343:
+^I $

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#481: FILE: lib/librte_compressdev/rte_comp.h:345:
+	/*
+	TODO - Are any extra params needed on stateful op or are all in xform?

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#561: FILE: lib/librte_compressdev/rte_comp.h:425:
+		unsigned nb_elts, unsigned cache_size, uint16_t priv_size,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#561: FILE: lib/librte_compressdev/rte_comp.h:425:
+		unsigned nb_elts, unsigned cache_size, uint16_t priv_size,

WARNING:BRACES: braces {} are not necessary for single statement blocks
#660: FILE: lib/librte_compressdev/rte_comp.h:524:
+		if (likely(priv_size >= size)) {
+			return (void *)(op + 1);
+		}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#901: FILE: lib/librte_compressdev/rte_compressdev.c:194:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1104: FILE: lib/librte_compressdev/rte_compressdev.c:397:
+	unsigned i;

WARNING:TABSTOP: Statements should start on a tabstop
#1123: FILE: lib/librte_compressdev/rte_compressdev.c:416:
+	    return -EINVAL;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1336: FILE: lib/librte_compressdev/rte_compressdev.c:629:
+					(unsigned)dev_id);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1740: FILE: lib/librte_compressdev/rte_compressdev.c:1033:
+		__rte_unused unsigned i)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1754: FILE: lib/librte_compressdev/rte_compressdev.c:1047:
+		unsigned nb_elts, unsigned cache_size, uint16_t priv_size,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1754: FILE: lib/librte_compressdev/rte_compressdev.c:1047:
+		unsigned nb_elts, unsigned cache_size, uint16_t priv_size,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1759: FILE: lib/librte_compressdev/rte_compressdev.c:1052:
+	unsigned elt_size = sizeof(struct rte_comp_op) +

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1952: FILE: lib/librte_compressdev/rte_compressdev.h:58:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1953: FILE: lib/librte_compressdev/rte_compressdev.h:59:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1957: FILE: lib/librte_compressdev/rte_compressdev.h:63:
+		RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1958: FILE: lib/librte_compressdev/rte_compressdev.h:64:
+			RTE_FMT_TAIL(__VA_ARGS__,)))
 			                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1963: FILE: lib/librte_compressdev/rte_compressdev.h:69:
+		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1964: FILE: lib/librte_compressdev/rte_compressdev.h:70:
+			__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1968: FILE: lib/librte_compressdev/rte_compressdev.h:74:
+		RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "
", \
 		                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1969: FILE: lib/librte_compressdev/rte_compressdev.h:75:
+			dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
 			                                       ^

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2085: FILE: lib/librte_compressdev/rte_compressdev.h:191:
+	unsigned max_nb_queue_pairs;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2098: FILE: lib/librte_compressdev/rte_compressdev.h:204:
+^I $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2230: FILE: lib/librte_compressdev/rte_compressdev.h:336:
+^I * then compression using dynamic huffman encoding may not be possible,^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#2234: FILE: lib/librte_compressdev/rte_compressdev.h:340:
+^I * will use its default value.  $

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3245: FILE: lib/librte_compressdev/rte_compressdev_pmd.h:283:
+		struct rte_compressdev *dev, unsigned nb_objs,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3246: FILE: lib/librte_compressdev/rte_compressdev_pmd.h:284:
+		unsigned obj_cache_size, int socket_id);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3258: FILE: lib/librte_compressdev/rte_compressdev_pmd.h:296:
+typedef unsigned (*compressdev_get_session_private_size_t)(

ERROR:TRAILING_WHITESPACE: trailing whitespace
#3523: FILE: lib/librte_compressdev/rte_compressdev_version.map:20:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#3530: FILE: lib/librte_compressdev/rte_compressdev_version.map:27:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#3535: FILE: lib/librte_compressdev/rte_compressdev_version.map:32:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#3542: FILE: lib/librte_compressdev/rte_compressdev_version.map:39:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#3544: FILE: lib/librte_compressdev/rte_compressdev_version.map:41:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#3561: FILE: lib/librte_compressdev/rte_compressdev_version.map:58:
+^I$

total: 27 errors, 18 warnings, 3478 lines checked

          parent reply	other threads:[~2017-11-27 11:25 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1511542566-10455-1-git-send-email-fiona.trahe@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127112539.38EC72C55@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).