From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 98C111B195; Mon, 27 Nov 2017 21:03:42 +0100 (CET)
In-Reply-To: <20171127200115.31049-5-roy.fan.zhang@intel.com>
References: <20171127200115.31049-5-roy.fan.zhang@intel.com>
To: test-report@dpdk.org
Cc: Fan Zhang <roy.fan.zhang@intel.com>
Message-Id: <20171127200342.98C111B195@dpdk.org>
Date: Mon, 27 Nov 2017 21:03:42 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31688 [PATCH 04/12]
	lib/librte_vhost: add session messsage handler
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Nov 2017 20:03:42 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31688

_coding style issues_


WARNING:TYPO_SPELLING: 'messsage' may be misspelled - perhaps 'message'?
#5: 
Subject: [dpdk-dev] [PATCH 04/12] lib/librte_vhost: add session messsage handler

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#82: FILE: lib/librte_vhost/vhost_crypto.c:54:
+#define INHDR_LEN ^I^I(sizeof(struct virtio_crypto_inhdr))$

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#115: FILE: lib/librte_vhost/vhost_crypto.c:87:
+#define GPA_TO_VVA(t, m, a)						\
+		(t)(uintptr_t)rte_vhost_gpa_to_vva(m, a)

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#119: FILE: lib/librte_vhost/vhost_crypto.c:91:
+#define REQ_OP_OFFSET ^I^I(IV_OFFSET + VHOST_CRYPTO_MAX_IV_LEN)$

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#249: FILE: lib/librte_vhost/vhost_crypto.c:221:
+static int
+transform_cipher_param(struct rte_crypto_sym_xform *xform,
+		VhostUserCryptoSessionParam *param) {

ERROR:SPACING: space required before the open parenthesis '('
#337: FILE: lib/librte_vhost/vhost_crypto.c:309:
+	switch(sess_param->op_type) {

total: 3 errors, 3 warnings, 447 lines checked