From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id BCCFE2BE9; Tue, 28 Nov 2017 18:42:27 +0100 (CET)
In-Reply-To: <1511890808-6072-3-git-send-email-erik.g.carrillo@intel.com>
References: <1511890808-6072-3-git-send-email-erik.g.carrillo@intel.com>
To: test-report@dpdk.org
Cc: Erik Carrillo <erik.g.carrillo@intel.com>
Message-Id: <20171128174227.BCCFE2BE9@dpdk.org>
Date: Tue, 28 Nov 2017 18:42:27 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31733 [PATCH RFC v4 2/4] eventtimer:
	add common code
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2017 17:42:27 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31733

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#148: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:57:
+#define ADAPTER_VALID_OR_ERR_RET(adapter, retval) do { \
+	if (!adapter_valid(adapter))		       \
+		return retval;			       \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#153: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:62:
+#define FUNC_PTR_OR_ERR_RET(func, errval) do { \
+	if ((func) == NULL)		       \
+		return errval;		       \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#158: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:67:
+#define FUNC_PTR_OR_NULL_RET_WITH_ERRNO(func, errval) do { \
+	if ((func) == NULL) {				   \
+		rte_errno = errval;			   \
+		return NULL;				   \
+	}						   \
+} while (0)

total: 0 errors, 3 warnings, 668 lines checked