From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Moti H <motih@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw31743 [PATCH RFC] net/failsafe: add Rx interrupts
Date: Wed, 29 Nov 2017 10:08:36 +0100 (CET) [thread overview]
Message-ID: <20171129090836.2E8082C54@dpdk.org> (raw)
In-Reply-To: <1511946476-47368-1-git-send-email-motih@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31743
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19:
to be handled by the application while internally it manages several devices
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#272: FILE: drivers/net/failsafe/failsafe_intr.c:164:
+
+ }
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxq->event_fd < 0'
#365: FILE: drivers/net/failsafe/failsafe_intr.c:257:
+ if (!rxq || (rxq->event_fd < 0)) {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#431: FILE: drivers/net/failsafe/failsafe_intr.c:323:
+ * Apply interrupt control operation on all subdevices.
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#432: FILE: drivers/net/failsafe/failsafe_intr.c:324:
+ *
+ * @param priv
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxq->event_fd <= 0'
#571: FILE: drivers/net/failsafe/failsafe_intr.c:463:
+ if (!rxq || (rxq->event_fd <= 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxq->event_fd <= 0'
#609: FILE: drivers/net/failsafe/failsafe_intr.c:501:
+ if (!rxq || (rxq->event_fd <= 0)) {
total: 0 errors, 3 warnings, 4 checks, 677 lines checked
parent reply other threads:[~2017-11-29 9:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1511946476-47368-1-git-send-email-motih@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129090836.2E8082C54@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=motih@mellanox.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).