From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 2E8082C54; Wed, 29 Nov 2017 10:08:36 +0100 (CET)
In-Reply-To: <1511946476-47368-1-git-send-email-motih@mellanox.com>
References: <1511946476-47368-1-git-send-email-motih@mellanox.com>
To: test-report@dpdk.org
Cc: Moti H <motih@mellanox.com>
Message-Id: <20171129090836.2E8082C54@dpdk.org>
Date: Wed, 29 Nov 2017 10:08:36 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31743 [PATCH RFC] net/failsafe: add
	Rx interrupts
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Nov 2017 09:08:36 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31743

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19: 
to be handled by the application while internally it manages several devices

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#272: FILE: drivers/net/failsafe/failsafe_intr.c:164:
+
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxq->event_fd < 0'
#365: FILE: drivers/net/failsafe/failsafe_intr.c:257:
+		if (!rxq || (rxq->event_fd < 0)) {

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#431: FILE: drivers/net/failsafe/failsafe_intr.c:323:
+ * Apply interrupt control operation on all subdevices.
+  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#432: FILE: drivers/net/failsafe/failsafe_intr.c:324:
+  *
+ * @param priv

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxq->event_fd <= 0'
#571: FILE: drivers/net/failsafe/failsafe_intr.c:463:
+	if (!rxq || (rxq->event_fd <= 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxq->event_fd <= 0'
#609: FILE: drivers/net/failsafe/failsafe_intr.c:501:
+	if (!rxq || (rxq->event_fd <= 0)) {

total: 0 errors, 3 warnings, 4 checks, 677 lines checked