From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Subject: [dpdk-test-report] |WARNING| pw31754 [PATCH] net/bonding: fix link status check
Date: Wed, 29 Nov 2017 15:57:29 +0100 (CET) [thread overview]
Message-ID: <20171129145729.694D93230@dpdk.org> (raw)
In-Reply-To: <20171129145349.43448-1-tomaszx.kulasek@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31754
_coding style issues_
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#93: FILE: drivers/net/bonding/rte_eth_bond_api.c:289:
if (internals->slave_count < 1) {
+
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#95: FILE: drivers/net/bonding/rte_eth_bond_api.c:291:
+ * from first active slave) */
WARNING:LONG_LINE: line over 90 characters
#132: FILE: drivers/net/bonding/rte_eth_bond_api.c:368:
+ slave_port_id) == internals->active_slave_count) {
WARNING:LONG_LINE_COMMENT: line over 90 characters
#135: FILE: drivers/net/bonding/rte_eth_bond_api.c:371:
+ /* Inherit dev link properties from first active slave */
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around slave_eth_dev->data->dev_link
#137: FILE: drivers/net/bonding/rte_eth_bond_api.c:373:
+ &(slave_eth_dev->data->dev_link));
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (32, 48)
#138: FILE: drivers/net/bonding/rte_eth_bond_api.c:374:
+ } else if (link_properties_valid(bonded_eth_dev,
[...]
+ RTE_BOND_LOG(ERR, "Invalid link properties for slave %d"
WARNING:LONG_LINE: line over 90 characters
#139: FILE: drivers/net/bonding/rte_eth_bond_api.c:375:
+ &slave_eth_dev->data->dev_link) != 0) {
WARNING:LONG_LINE: line over 90 characters
#141: FILE: drivers/net/bonding/rte_eth_bond_api.c:377:
+ " in bonding mode %d", slave_port_id,
total: 0 errors, 6 warnings, 2 checks, 99 lines checked
parent reply other threads:[~2017-11-29 14:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171129145349.43448-1-tomaszx.kulasek@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129145729.694D93230@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).