From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 694D93230; Wed, 29 Nov 2017 15:57:29 +0100 (CET)
In-Reply-To: <20171129145349.43448-1-tomaszx.kulasek@intel.com>
References: <20171129145349.43448-1-tomaszx.kulasek@intel.com>
To: test-report@dpdk.org
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Message-Id: <20171129145729.694D93230@dpdk.org>
Date: Wed, 29 Nov 2017 15:57:29 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31754 [PATCH] net/bonding: fix link
	status check
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Nov 2017 14:57:29 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31754

_coding style issues_


CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#93: FILE: drivers/net/bonding/rte_eth_bond_api.c:289:
 	if (internals->slave_count < 1) {
+

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#95: FILE: drivers/net/bonding/rte_eth_bond_api.c:291:
+		 * from first active slave) */

WARNING:LONG_LINE: line over 90 characters
#132: FILE: drivers/net/bonding/rte_eth_bond_api.c:368:
+						slave_port_id) == internals->active_slave_count) {

WARNING:LONG_LINE_COMMENT: line over 90 characters
#135: FILE: drivers/net/bonding/rte_eth_bond_api.c:371:
+					/* Inherit dev link properties from first active slave */

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around slave_eth_dev->data->dev_link
#137: FILE: drivers/net/bonding/rte_eth_bond_api.c:373:
+							&(slave_eth_dev->data->dev_link));

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (32, 48)
#138: FILE: drivers/net/bonding/rte_eth_bond_api.c:374:
+				} else if (link_properties_valid(bonded_eth_dev,
[...]
+						RTE_BOND_LOG(ERR, "Invalid link properties for slave %d"

WARNING:LONG_LINE: line over 90 characters
#139: FILE: drivers/net/bonding/rte_eth_bond_api.c:375:
+							&slave_eth_dev->data->dev_link) != 0) {

WARNING:LONG_LINE: line over 90 characters
#141: FILE: drivers/net/bonding/rte_eth_bond_api.c:377:
+								" in bonding mode %d", slave_port_id,

total: 0 errors, 6 warnings, 2 checks, 99 lines checked