From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw31761 [PATCH] bus: add vmbus support
Date: Wed, 29 Nov 2017 21:14:37 +0100 (CET) [thread overview]
Message-ID: <20171129201437.CA1E53256@dpdk.org> (raw)
In-Reply-To: <20171129201404.9308-1-sthemmin@microsoft.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31761
_coding style issues_
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#75: FILE: MAINTAINERS:313:
+M: Stephen Hemminger <sthemmin@microsoft.com>
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#76: FILE: MAINTAINERS:314:
+F: drivers/bus/vmbus/
ERROR:CODE_INDENT: code indent should use tabs where possible
#510: FILE: drivers/bus/vmbus/common/common_chan.c:111:
+ ^Istruct vmbus_chanpkt pkt;$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#510: FILE: drivers/bus/vmbus/common/common_chan.c:111:
+ ^Istruct vmbus_chanpkt pkt;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#510: FILE: drivers/bus/vmbus/common/common_chan.c:111:
+ ^Istruct vmbus_chanpkt pkt;$
WARNING:TYPO_SPELLING: 'propogate' may be misspelled - perhaps 'propagate'?
#584: FILE: drivers/bus/vmbus/common/common_chan.c:185:
+ /* if caller is batching, just propogate the status */
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#1036: FILE: drivers/bus/vmbus/common/common_vmbus.c:56:
+extern struct rte_vmbus_bus rte_vmbus_bus;
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct vmbus_channel *' should also have an identifier name
#1513: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:212:
+void rte_vmbus_chan_close(struct vmbus_channel *);
WARNING:TYPO_SPELLING: 'incomming' may be misspelled - perhaps 'incoming'?
#1545: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:244:
+ * Return true if no data present in incomming ring.
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1558: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:257:
+^I$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1566: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:265:
+ * ^Ipacket etc.$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1592: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:291:
+ */ $
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1603: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:302:
+ * ^Ipacket etc.$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1901: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:155:
+ uint32_t len;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1902: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:156:
+ uint32_t ofs;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1903: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:157:
+ uint64_t page[0];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1908: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:162:
+ uint32_t len;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1909: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:163:
+ uint32_t ofs;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1910: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:164:
+ uint64_t page;$
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#2402: FILE: drivers/bus/vmbus/linuxapp/vmbus_bus.c:58:
+extern struct rte_vmbus_bus rte_vmbus_bus;
ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#2789: FILE: drivers/bus/vmbus/linuxapp/vmbus_uio.c:55:
+static void *vmbus_map_addr = NULL;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2871: FILE: drivers/bus/vmbus/linuxapp/vmbus_uio.c:137:
+ unsigned i = 0;
total: 4 errors, 18 warnings, 2799 lines checked
parent reply other threads:[~2017-11-29 20:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171129201404.9308-1-sthemmin@microsoft.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129201437.CA1E53256@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).