From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id CA1E53256; Wed, 29 Nov 2017 21:14:37 +0100 (CET)
In-Reply-To: <20171129201404.9308-1-sthemmin@microsoft.com>
References: <20171129201404.9308-1-sthemmin@microsoft.com>
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20171129201437.CA1E53256@dpdk.org>
Date: Wed, 29 Nov 2017 21:14:37 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31761 [PATCH] bus: add vmbus support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Nov 2017 20:14:37 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31761

_coding style issues_


WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#75: FILE: MAINTAINERS:313:
+M: Stephen Hemminger <sthemmin@microsoft.com>

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#76: FILE: MAINTAINERS:314:
+F: drivers/bus/vmbus/

ERROR:CODE_INDENT: code indent should use tabs where possible
#510: FILE: drivers/bus/vmbus/common/common_chan.c:111:
+ ^Istruct vmbus_chanpkt pkt;$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#510: FILE: drivers/bus/vmbus/common/common_chan.c:111:
+ ^Istruct vmbus_chanpkt pkt;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#510: FILE: drivers/bus/vmbus/common/common_chan.c:111:
+ ^Istruct vmbus_chanpkt pkt;$

WARNING:TYPO_SPELLING: 'propogate' may be misspelled - perhaps 'propagate'?
#584: FILE: drivers/bus/vmbus/common/common_chan.c:185:
+	/* if caller is batching, just propogate the status */

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#1036: FILE: drivers/bus/vmbus/common/common_vmbus.c:56:
+extern struct rte_vmbus_bus rte_vmbus_bus;

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct vmbus_channel *' should also have an identifier name
#1513: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:212:
+void rte_vmbus_chan_close(struct vmbus_channel *);

WARNING:TYPO_SPELLING: 'incomming' may be misspelled - perhaps 'incoming'?
#1545: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:244:
+ *	Return true if no data present in incomming ring.

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1558: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:257:
+^I$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1566: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:265:
+ * ^Ipacket etc.$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1592: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:291:
+ */ $

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1603: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:302:
+ * ^Ipacket etc.$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1901: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:155:
+       uint32_t        len;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1902: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:156:
+       uint32_t        ofs;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1903: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:157:
+       uint64_t        page[0];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1908: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:162:
+       uint32_t        len;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1909: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:163:
+       uint32_t        ofs;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1910: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:164:
+       uint64_t        page;$

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#2402: FILE: drivers/bus/vmbus/linuxapp/vmbus_bus.c:58:
+extern struct rte_vmbus_bus rte_vmbus_bus;

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#2789: FILE: drivers/bus/vmbus/linuxapp/vmbus_uio.c:55:
+static void *vmbus_map_addr = NULL;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2871: FILE: drivers/bus/vmbus/linuxapp/vmbus_uio.c:137:
+	unsigned i = 0;

total: 4 errors, 18 warnings, 2799 lines checked