* [dpdk-test-report] |WARNING| pw31761 [PATCH] bus: add vmbus support
[not found] <20171129201404.9308-1-sthemmin@microsoft.com>
@ 2017-11-29 20:14 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-11-29 20:14 UTC (permalink / raw)
To: test-report; +Cc: Stephen Hemminger
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31761
_coding style issues_
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#75: FILE: MAINTAINERS:313:
+M: Stephen Hemminger <sthemmin@microsoft.com>
WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#76: FILE: MAINTAINERS:314:
+F: drivers/bus/vmbus/
ERROR:CODE_INDENT: code indent should use tabs where possible
#510: FILE: drivers/bus/vmbus/common/common_chan.c:111:
+ ^Istruct vmbus_chanpkt pkt;$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#510: FILE: drivers/bus/vmbus/common/common_chan.c:111:
+ ^Istruct vmbus_chanpkt pkt;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#510: FILE: drivers/bus/vmbus/common/common_chan.c:111:
+ ^Istruct vmbus_chanpkt pkt;$
WARNING:TYPO_SPELLING: 'propogate' may be misspelled - perhaps 'propagate'?
#584: FILE: drivers/bus/vmbus/common/common_chan.c:185:
+ /* if caller is batching, just propogate the status */
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#1036: FILE: drivers/bus/vmbus/common/common_vmbus.c:56:
+extern struct rte_vmbus_bus rte_vmbus_bus;
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct vmbus_channel *' should also have an identifier name
#1513: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:212:
+void rte_vmbus_chan_close(struct vmbus_channel *);
WARNING:TYPO_SPELLING: 'incomming' may be misspelled - perhaps 'incoming'?
#1545: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:244:
+ * Return true if no data present in incomming ring.
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1558: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:257:
+^I$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1566: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:265:
+ * ^Ipacket etc.$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1592: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:291:
+ */ $
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1603: FILE: drivers/bus/vmbus/common/include/rte_vmbus.h:302:
+ * ^Ipacket etc.$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1901: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:155:
+ uint32_t len;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1902: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:156:
+ uint32_t ofs;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1903: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:157:
+ uint64_t page[0];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1908: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:162:
+ uint32_t len;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1909: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:163:
+ uint32_t ofs;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1910: FILE: drivers/bus/vmbus/common/include/vmbus_reg.h:164:
+ uint64_t page;$
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#2402: FILE: drivers/bus/vmbus/linuxapp/vmbus_bus.c:58:
+extern struct rte_vmbus_bus rte_vmbus_bus;
ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#2789: FILE: drivers/bus/vmbus/linuxapp/vmbus_uio.c:55:
+static void *vmbus_map_addr = NULL;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2871: FILE: drivers/bus/vmbus/linuxapp/vmbus_uio.c:137:
+ unsigned i = 0;
total: 4 errors, 18 warnings, 2799 lines checked
^ permalink raw reply [flat|nested] only message in thread