From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ophir Munk <ophirmu@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw31781 [PATCH RFC 2/2] net/tap: add eBPF instructions
Date: Thu, 30 Nov 2017 09:02:43 +0100 (CET) [thread overview]
Message-ID: <20171130080243.22F902B9E@dpdk.org> (raw)
In-Reply-To: <1512028870-13597-2-git-send-email-ophirmu@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31781
_coding style issues_
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#58: FILE: drivers/net/tap/tap_bpf_api.h:2:
+/*******************************************************************************
+
WARNING:CONSTANT_CONVERSION: __constant_htons should be htons
#115: FILE: drivers/net/tap/tap_bpf_api.h:59:
+# define htons(X) __constant_htons((X))
WARNING:CONSTANT_CONVERSION: __constant_ntohs should be ntohs
#119: FILE: drivers/net/tap/tap_bpf_api.h:63:
+# define ntohs(X) __constant_ntohs((X))
WARNING:INLINE: plain inline is preferred over __inline__
#130: FILE: drivers/net/tap/tap_bpf_api.h:74:
+#ifndef __inline__
WARNING:INLINE: plain inline is preferred over __inline__
#131: FILE: drivers/net/tap/tap_bpf_api.h:75:
+# define __inline__ __attribute__((always_inline))
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#192: FILE: drivers/net/tap/tap_bpf_api.h:136:
+# define __BPF_FUNC(NAME, ...) \
+ (* NAME)(__VA_ARGS__)__maybe_unused
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#197: FILE: drivers/net/tap/tap_bpf_api.h:141:
+# define BPF_FUNC(NAME, ...) \
+ __BPF_FUNC(NAME, __VA_ARGS__) = (void *)BPF_FUNC_##NAME
CHECK:SPACING: No space is necessary after a cast
#276: FILE: drivers/net/tap/tap_bpf_api.h:220:
+ (void *) BPF_FUNC_perf_event_output;
CHECK:SPACING: No space is necessary after a cast
#298: FILE: drivers/net/tap/tap_bpf_api.h:242:
+# define lock_xadd(ptr, val) ((void) __sync_fetch_and_add(ptr, val))
CHECK:REDUNDANT_CODE: if this code is redundant consider removing it
#317: FILE: drivers/net/tap/tap_bpf_api.h:261:
+#if 0
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(cls_q_insns)
#457: FILE: drivers/net/tap/tap_bpf_insns.c:119:
+ (sizeof(cls_q_insns) / sizeof(cls_q_insns[0]))
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(tailing_insns)
#502: FILE: drivers/net/tap/tap_bpf_insns.c:164:
+ (sizeof(tailing_insns) / sizeof(tailing_insns[0]))
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(hash_appending_insns)
#548: FILE: drivers/net/tap/tap_bpf_insns.c:210:
+ (sizeof(hash_appending_insns) / sizeof(hash_appending_insns[0]))
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(queue_setting_insns)
#620: FILE: drivers/net/tap/tap_bpf_insns.c:282:
+ (sizeof(queue_setting_insns) / sizeof(queue_setting_insns[0]))
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l2_src_hash_insns)
#1241: FILE: drivers/net/tap/tap_bpf_insns.c:903:
+ (sizeof(l2_src_hash_insns) / sizeof(l2_src_hash_insns[0]))
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l2_dst_hash_insns)
#1848: FILE: drivers/net/tap/tap_bpf_insns.c:1510:
+ (sizeof(l2_dst_hash_insns) / sizeof(l2_dst_hash_insns[0]))
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l3_dst_hash_insns)
#3608: FILE: drivers/net/tap/tap_bpf_insns.c:3270:
+ (sizeof(l3_dst_hash_insns) / sizeof(l3_dst_hash_insns[0]))
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l3_src_hash_insns)
#5357: FILE: drivers/net/tap/tap_bpf_insns.c:5019:
+ (sizeof(l3_src_hash_insns) / sizeof(l3_src_hash_insns[0]))
WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(l4_src_hash_insns)
#5699: FILE: drivers/net/tap/tap_bpf_insns.c:5361:
+ (sizeof(l4_src_hash_insns) / sizeof(l4_src_hash_insns[0]))
CHECK:ARCH_DEFINES: architecture specific defines should be avoided
#5721: FILE: drivers/net/tap/tap_bpf_insns.c:5383:
+# if defined(__i386__)
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string
#5904: FILE: drivers/net/tap/tap_bpf_program.c:133:
+ printt("hash(): rss key is not configured
");
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string
#5926: FILE: drivers/net/tap/tap_bpf_program.c:155:
+ printt("hash(%d): hash = %x (off = %d)
",
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string
#5939: FILE: drivers/net/tap/tap_bpf_program.c:168:
+ printt("hash(%d): hash = %x (off = %d)
",
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string
#5962: FILE: drivers/net/tap/tap_bpf_program.c:191:
+ printt("hash(%d): hash = %x (off = %d)
",
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string
#5977: FILE: drivers/net/tap/tap_bpf_program.c:206:
+ printt("hash(%d): hash = %x (off = %d)
",
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string
#6001: FILE: drivers/net/tap/tap_bpf_program.c:230:
+ printt("hash(%d): hash = %x (off = %d)
",
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string
#6016: FILE: drivers/net/tap/tap_bpf_program.c:245:
+ printt("hash(%d): hash = %x (off = %d)
",
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'f == HASH_FIELD_L4_SRC'
#6030: FILE: drivers/net/tap/tap_bpf_program.c:259:
+ if ((ip_proto == IPPROTO_TCP || ip_proto == IPPROTO_UDP) &&
+ (rsskey->hash_fields & (1 << HASH_FIELD_L4_SRC)) &&
+ (f == HASH_FIELD_L4_SRC)) {
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'hash', this function's name, in a string
#6039: FILE: drivers/net/tap/tap_bpf_program.c:268:
+ printt("hash(%d): hash = %x (off = %d)
",
total: 2 errors, 22 warnings, 5 checks, 6100 lines checked
parent reply other threads:[~2017-11-30 8:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1512028870-13597-2-git-send-email-ophirmu@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130080243.22F902B9E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ophirmu@mellanox.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).