From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Zhiyong Yang <zhiyong.yang@intel.com>
Subject: [dpdk-test-report] |WARNING| pw31788 [PATCH 04/11] net/vhostpci: add basic framework
Date: Thu, 30 Nov 2017 10:47:58 +0100 (CET) [thread overview]
Message-ID: <20171130094758.27A289B6B@dpdk.org> (raw)
In-Reply-To: <20171130094657.11470-5-zhiyong.yang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31788
_coding style issues_
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#270: FILE: drivers/net/vhostpci/vhostpci_ethdev.c:208:
+{
+
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#289: FILE: drivers/net/vhostpci/vhostpci_ethdev.c:227:
+
+}
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around dev->data->dev_link
#301: FILE: drivers/net/vhostpci/vhostpci_ethdev.c:239:
+ struct rte_eth_link *dst = &(dev->data->dev_link);
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#467: FILE: drivers/net/vhostpci/vhostpci_ethdev.c:405:
+ for (i = 0; i < VHOSTPCI_MAX_QUEUE_PAIRS * 2; i++) {
+
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#699: FILE: drivers/net/vhostpci/vhostpci_pci.c:92:
+
+}
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#825: FILE: drivers/net/vhostpci/vhostpci_pci.c:218:
+ if (offset + length > dev->mem_resource[bar].len) {
+
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#827: FILE: drivers/net/vhostpci/vhostpci_pci.c:220:
+ "invalid cap: overflows bar space: %u > %" PRIu64,
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#878: FILE: drivers/net/vhostpci/vhostpci_pci.c:271:
+ if (cap.cap_vndr != PCI_CAP_ID_VNDR) {
+
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#931: FILE: drivers/net/vhostpci/vhostpci_pci.c:324:
+{
+
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#937: FILE: drivers/net/vhostpci/vhostpci_pci.c:330:
+ return 0;
+ } else {
total: 0 errors, 1 warnings, 892 lines checked
parent reply other threads:[~2017-11-30 9:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171130094657.11470-5-zhiyong.yang@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130094758.27A289B6B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).