From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 27A289B6B; Thu, 30 Nov 2017 10:47:58 +0100 (CET)
In-Reply-To: <20171130094657.11470-5-zhiyong.yang@intel.com>
References: <20171130094657.11470-5-zhiyong.yang@intel.com>
To: test-report@dpdk.org
Cc: Zhiyong Yang <zhiyong.yang@intel.com>
Message-Id: <20171130094758.27A289B6B@dpdk.org>
Date: Thu, 30 Nov 2017 10:47:58 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31788 [PATCH 04/11] net/vhostpci:
	add basic framework
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Nov 2017 09:47:58 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31788

_coding style issues_


CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#270: FILE: drivers/net/vhostpci/vhostpci_ethdev.c:208:
+{
+

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#289: FILE: drivers/net/vhostpci/vhostpci_ethdev.c:227:
+
+}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around dev->data->dev_link
#301: FILE: drivers/net/vhostpci/vhostpci_ethdev.c:239:
+	struct rte_eth_link *dst = &(dev->data->dev_link);

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#467: FILE: drivers/net/vhostpci/vhostpci_ethdev.c:405:
+	for (i = 0; i < VHOSTPCI_MAX_QUEUE_PAIRS * 2; i++) {
+

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#699: FILE: drivers/net/vhostpci/vhostpci_pci.c:92:
+
+}

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#825: FILE: drivers/net/vhostpci/vhostpci_pci.c:218:
+	if (offset + length > dev->mem_resource[bar].len) {
+

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#827: FILE: drivers/net/vhostpci/vhostpci_pci.c:220:
+			"invalid cap: overflows bar space: %u > %" PRIu64,

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#878: FILE: drivers/net/vhostpci/vhostpci_pci.c:271:
+		if (cap.cap_vndr != PCI_CAP_ID_VNDR) {
+

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#931: FILE: drivers/net/vhostpci/vhostpci_pci.c:324:
+{
+

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#937: FILE: drivers/net/vhostpci/vhostpci_pci.c:330:
+		return 0;
+	} else {

total: 0 errors, 1 warnings, 892 lines checked