From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 743142C3F; Thu, 30 Nov 2017 12:48:13 +0100 (CET)
In-Reply-To: <1512042367-6361-1-git-send-email-hemant.agrawal@nxp.com>
References: <1512042367-6361-1-git-send-email-hemant.agrawal@nxp.com>
To: test-report@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Message-Id: <20171130114813.743142C3F@dpdk.org>
Date: Thu, 30 Nov 2017 12:48:13 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31796 [PATCH 1/3] kni: support for
	MAC addr change
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Nov 2017 11:48:13 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31796

_coding style issues_


WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#328: FILE: lib/librte_kni/rte_kni.c:742:
+	if ((NULL == ops->change_mtu)

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#329: FILE: lib/librte_kni/rte_kni.c:743:
+		&& (NULL == ops->config_network_if)

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#330: FILE: lib/librte_kni/rte_kni.c:744:
+		&& (NULL == ops->config_mac_address))

total: 0 errors, 3 warnings, 308 lines checked