From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ravi Kumar <ravi1.kumar@amd.com>
Subject: [dpdk-test-report] |WARNING| pw31801 [PATCH 02/16] net/axgbe: add register map and related macros
Date: Thu, 30 Nov 2017 14:13:27 +0100 (CET) [thread overview]
Message-ID: <20171130131327.123F71B21D@dpdk.org> (raw)
In-Reply-To: <1512047472-118050-2-git-send-email-Ravi1.kumar@amd.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31801
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_var' - possible side-effects?
#1314: FILE: drivers/net/axgbe/axgbe_common.h:1457:
+#define SET_BITS(_var, _index, _width, _val) \
+do { \
+ (_var) &= ~(((0x1 << (_width)) - 1) << (_index)); \
+ (_var) |= (((_val) & ((0x1 << (_width)) - 1)) << (_index)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_index' - possible side-effects?
#1314: FILE: drivers/net/axgbe/axgbe_common.h:1457:
+#define SET_BITS(_var, _index, _width, _val) \
+do { \
+ (_var) &= ~(((0x1 << (_width)) - 1) << (_index)); \
+ (_var) |= (((_val) & ((0x1 << (_width)) - 1)) << (_index)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_width' - possible side-effects?
#1314: FILE: drivers/net/axgbe/axgbe_common.h:1457:
+#define SET_BITS(_var, _index, _width, _val) \
+do { \
+ (_var) &= ~(((0x1 << (_width)) - 1) << (_index)); \
+ (_var) |= (((_val) & ((0x1 << (_width)) - 1)) << (_index)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_var' - possible side-effects?
#1323: FILE: drivers/net/axgbe/axgbe_common.h:1466:
+#define SET_BITS_LE(_var, _index, _width, _val) \
+do { \
+ (_var) &= rte_cpu_to_le_32(~(((0x1 << (_width)) - 1) << (_index)));\
+ (_var) |= rte_cpu_to_le_32((((_val) & \
+ ((0x1 << (_width)) - 1)) << (_index))); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_index' - possible side-effects?
#1323: FILE: drivers/net/axgbe/axgbe_common.h:1466:
+#define SET_BITS_LE(_var, _index, _width, _val) \
+do { \
+ (_var) &= rte_cpu_to_le_32(~(((0x1 << (_width)) - 1) << (_index)));\
+ (_var) |= rte_cpu_to_le_32((((_val) & \
+ ((0x1 << (_width)) - 1)) << (_index))); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_width' - possible side-effects?
#1323: FILE: drivers/net/axgbe/axgbe_common.h:1466:
+#define SET_BITS_LE(_var, _index, _width, _val) \
+do { \
+ (_var) &= rte_cpu_to_le_32(~(((0x1 << (_width)) - 1) << (_index)));\
+ (_var) |= rte_cpu_to_le_32((((_val) & \
+ ((0x1 << (_width)) - 1)) << (_index))); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1376: FILE: drivers/net/axgbe/axgbe_common.h:1519:
+#define AXGMAC_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1376: FILE: drivers/net/axgbe/axgbe_common.h:1519:
+#define AXGMAC_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1402: FILE: drivers/net/axgbe/axgbe_common.h:1545:
+#define AXGMAC_MTL_IOWRITE_BITS(_pdata, _n, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_MTL_IOREAD((_pdata), (_n), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_MTL_IOWRITE((_pdata), (_n), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#1402: FILE: drivers/net/axgbe/axgbe_common.h:1545:
+#define AXGMAC_MTL_IOWRITE_BITS(_pdata, _n, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_MTL_IOREAD((_pdata), (_n), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_MTL_IOWRITE((_pdata), (_n), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1402: FILE: drivers/net/axgbe/axgbe_common.h:1545:
+#define AXGMAC_MTL_IOWRITE_BITS(_pdata, _n, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_MTL_IOREAD((_pdata), (_n), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_MTL_IOWRITE((_pdata), (_n), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_channel' - possible side-effects?
#1426: FILE: drivers/net/axgbe/axgbe_common.h:1569:
+#define AXGMAC_DMA_IOWRITE_BITS(_channel, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_DMA_IOREAD((_channel), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_DMA_IOWRITE((_channel), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1426: FILE: drivers/net/axgbe/axgbe_common.h:1569:
+#define AXGMAC_DMA_IOWRITE_BITS(_channel, _reg, _field, _val) \
+do { \
+ u32 reg_val = AXGMAC_DMA_IOREAD((_channel), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ AXGMAC_DMA_IOWRITE((_channel), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1484: FILE: drivers/net/axgbe/axgbe_common.h:1627:
+#define XSIR0_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XSIR0_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XSIR0_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1484: FILE: drivers/net/axgbe/axgbe_common.h:1627:
+#define XSIR0_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XSIR0_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XSIR0_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1504: FILE: drivers/net/axgbe/axgbe_common.h:1647:
+#define XSIR1_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XSIR1_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XSIR1_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1504: FILE: drivers/net/axgbe/axgbe_common.h:1647:
+#define XSIR1_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XSIR1_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XSIR1_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1527: FILE: drivers/net/axgbe/axgbe_common.h:1670:
+#define XRXTX_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XRXTX_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XRXTX_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1527: FILE: drivers/net/axgbe/axgbe_common.h:1670:
+#define XRXTX_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u16 reg_val = XRXTX_IOREAD((_pdata), _reg); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XRXTX_IOWRITE((_pdata), _reg, reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1560: FILE: drivers/net/axgbe/axgbe_common.h:1703:
+#define XP_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = XP_IOREAD((_pdata), (_reg)); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XP_IOWRITE((_pdata), (_reg), reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1560: FILE: drivers/net/axgbe/axgbe_common.h:1703:
+#define XP_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = XP_IOREAD((_pdata), (_reg)); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XP_IOWRITE((_pdata), (_reg), reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1593: FILE: drivers/net/axgbe/axgbe_common.h:1736:
+#define XI2C_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = XI2C_IOREAD((_pdata), (_reg)); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XI2C_IOWRITE((_pdata), (_reg), reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1593: FILE: drivers/net/axgbe/axgbe_common.h:1736:
+#define XI2C_IOWRITE_BITS(_pdata, _reg, _field, _val) \
+do { \
+ u32 reg_val = XI2C_IOREAD((_pdata), (_reg)); \
+ SET_BITS(reg_val, \
+ _reg##_##_field##_INDEX, \
+ _reg##_##_field##_WIDTH, (_val)); \
+ XI2C_IOWRITE((_pdata), (_reg), reg_val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1607: FILE: drivers/net/axgbe/axgbe_common.h:1750:
+#define XMDIO_READ(_pdata, _mmd, _reg) \
+ ((_pdata)->hw_if.read_mmd_regs((_pdata), 0, \
+ MII_ADDR_C45 | ((_mmd) << 16) | ((_reg) & 0xffff)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1614: FILE: drivers/net/axgbe/axgbe_common.h:1757:
+#define XMDIO_WRITE(_pdata, _mmd, _reg, _val) \
+ ((_pdata)->hw_if.write_mmd_regs((_pdata), 0, \
+ MII_ADDR_C45 | ((_mmd) << 16) | ((_reg) & 0xffff), (_val)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects?
#1618: FILE: drivers/net/axgbe/axgbe_common.h:1761:
+#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \
+do { \
+ u32 mmd_val = XMDIO_READ((_pdata), (_mmd), (_reg)); \
+ mmd_val &= ~(_mask); \
+ mmd_val |= (_val); \
+ XMDIO_WRITE((_pdata), (_mmd), (_reg), (mmd_val)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mmd' - possible side-effects?
#1618: FILE: drivers/net/axgbe/axgbe_common.h:1761:
+#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \
+do { \
+ u32 mmd_val = XMDIO_READ((_pdata), (_mmd), (_reg)); \
+ mmd_val &= ~(_mask); \
+ mmd_val |= (_val); \
+ XMDIO_WRITE((_pdata), (_mmd), (_reg), (mmd_val)); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects?
#1618: FILE: drivers/net/axgbe/axgbe_common.h:1761:
+#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \
+do { \
+ u32 mmd_val = XMDIO_READ((_pdata), (_mmd), (_reg)); \
+ mmd_val &= ~(_mask); \
+ mmd_val |= (_val); \
+ XMDIO_WRITE((_pdata), (_mmd), (_reg), (mmd_val)); \
+} while (0)
total: 0 errors, 0 warnings, 28 checks, 1650 lines checked
parent reply other threads:[~2017-11-30 13:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1512047472-118050-2-git-send-email-Ravi1.kumar@amd.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130131327.123F71B21D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ravi1.kumar@amd.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).