automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ravi Kumar <ravi1.kumar@amd.com>
Subject: [dpdk-test-report] |WARNING| pw31804 [PATCH 05/16] net/axgbe: add phy initialization and related apis
Date: Thu, 30 Nov 2017 14:13:34 +0100 (CET)	[thread overview]
Message-ID: <20171130131334.72FF61B1A8@dpdk.org> (raw)
In-Reply-To: <1512047472-118050-5-git-send-email-Ravi1.kumar@amd.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31804

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseKR_Full>
#1097: FILE: drivers/net/axgbe/axgbe_mdio.c:134:
+	if (pdata->phy.advertising & ADVERTISED_10000baseKR_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseT_Full>
#1099: FILE: drivers/net/axgbe/axgbe_mdio.c:136:
+	else if (pdata->phy.advertising & ADVERTISED_10000baseT_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_2500baseX_Full>
#1101: FILE: drivers/net/axgbe/axgbe_mdio.c:138:
+	else if (pdata->phy.advertising & ADVERTISED_2500baseX_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseKX_Full>
#1103: FILE: drivers/net/axgbe/axgbe_mdio.c:140:
+	else if (pdata->phy.advertising & ADVERTISED_1000baseKX_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseT_Full>
#1105: FILE: drivers/net/axgbe/axgbe_mdio.c:142:
+	else if (pdata->phy.advertising & ADVERTISED_1000baseT_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_100baseT_Full>
#1107: FILE: drivers/net/axgbe/axgbe_mdio.c:144:
+	else if (pdata->phy.advertising & ADVERTISED_100baseT_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Autoneg>
#1133: FILE: drivers/net/axgbe/axgbe_mdio.c:170:
+	if (pdata->phy.advertising & ADVERTISED_Autoneg) {

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Pause>
#1150: FILE: drivers/net/axgbe/axgbe_mdio.c:187:
+	pdata->phy.advertising &= ~ADVERTISED_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Asym_Pause>
#1151: FILE: drivers/net/axgbe/axgbe_mdio.c:188:
+	pdata->phy.advertising &= ~ADVERTISED_Asym_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Autoneg>
#1805: FILE: drivers/net/axgbe/axgbe_phy_impl.c:633:
+		pdata->phy.supported |= SUPPORTED_Autoneg;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Pause>
#1806: FILE: drivers/net/axgbe/axgbe_phy_impl.c:634:
+		pdata->phy.supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Asym_Pause>
#1806: FILE: drivers/net/axgbe/axgbe_phy_impl.c:634:
+		pdata->phy.supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Backplane>
#1807: FILE: drivers/net/axgbe/axgbe_phy_impl.c:635:
+		pdata->phy.supported |= SUPPORTED_Backplane;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseKX_Full>
#1809: FILE: drivers/net/axgbe/axgbe_phy_impl.c:637:
+			pdata->phy.supported |= SUPPORTED_1000baseKX_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseKR_Full>
#1813: FILE: drivers/net/axgbe/axgbe_phy_impl.c:641:
+			pdata->phy.supported |= SUPPORTED_10000baseKR_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseR_FEC>
#1816: FILE: drivers/net/axgbe/axgbe_phy_impl.c:644:
+					SUPPORTED_10000baseR_FEC;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_2500baseX_Full>
#1825: FILE: drivers/net/axgbe/axgbe_phy_impl.c:653:
+		pdata->phy.supported |= SUPPORTED_2500baseX_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_100baseT_Full>
#1837: FILE: drivers/net/axgbe/axgbe_phy_impl.c:665:
+			pdata->phy.supported |= SUPPORTED_100baseT_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseT_Full>
#1841: FILE: drivers/net/axgbe/axgbe_phy_impl.c:669:
+			pdata->phy.supported |= SUPPORTED_1000baseT_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseT_Full>
#1894: FILE: drivers/net/axgbe/axgbe_phy_impl.c:722:
+			pdata->phy.supported |= SUPPORTED_10000baseT_Full;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->phydev_mode != AXGBE_MDIO_MODE_NONE'
#1944: FILE: drivers/net/axgbe/axgbe_phy_impl.c:772:
+	if ((phy_data->conn_type & AXGBE_CONN_TYPE_MDIO) &&
+	    (phy_data->phydev_mode != AXGBE_MDIO_MODE_NONE)) {

total: 0 errors, 0 warnings, 21 checks, 1899 lines checked

           reply	other threads:[~2017-11-30 13:13 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1512047472-118050-5-git-send-email-Ravi1.kumar@amd.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130131334.72FF61B1A8@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=ravi1.kumar@amd.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).