From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ravi Kumar <ravi1.kumar@amd.com>
Subject: [dpdk-test-report] |WARNING| pw31805 [PATCH 06/16] net/axgbe: add phy programming apis
Date: Thu, 30 Nov 2017 14:13:39 +0100 (CET) [thread overview]
Message-ID: <20171130131339.1AF571B21D@dpdk.org> (raw)
In-Reply-To: <1512047472-118050-6-git-send-email-Ravi1.kumar@amd.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31805
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseKX_Full>
#535: FILE: drivers/net/axgbe/axgbe_mdio.c:591:
+ if (!(pdata->phy.advertising & ADVERTISED_1000baseKX_Full) &&
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_2500baseX_Full>
#536: FILE: drivers/net/axgbe/axgbe_mdio.c:592:
+ !(pdata->phy.advertising & ADVERTISED_2500baseX_Full))
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseKR_Full>
#544: FILE: drivers/net/axgbe/axgbe_mdio.c:600:
+ if (!(pdata->phy.advertising & ADVERTISED_10000baseKR_Full))
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseR_FEC>
#682: FILE: drivers/net/axgbe/axgbe_mdio.c:738:
+ if (advertising & ADVERTISED_10000baseR_FEC)
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Pause>
#706: FILE: drivers/net/axgbe/axgbe_mdio.c:762:
+ if (advertising & ADVERTISED_Pause)
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Asym_Pause>
#711: FILE: drivers/net/axgbe/axgbe_mdio.c:767:
+ if (advertising & ADVERTISED_Asym_Pause)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pdata->phy.autoneg != AUTONEG_ENABLE'
#891: FILE: drivers/net/axgbe/axgbe_mdio.c:947:
+ if ((pdata->phy.autoneg != AUTONEG_ENABLE) || pdata->parallel_detect)
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Autoneg>
#1272: FILE: drivers/net/axgbe/axgbe_phy_impl.c:581:
+ pdata->phy.advertising &= ~ADVERTISED_Autoneg;
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_100baseT_Full>
#1275: FILE: drivers/net/axgbe/axgbe_phy_impl.c:584:
+ pdata->phy.advertising &= ~ADVERTISED_100baseT_Full;
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseT_Full>
#1276: FILE: drivers/net/axgbe/axgbe_phy_impl.c:585:
+ pdata->phy.advertising &= ~ADVERTISED_1000baseT_Full;
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseT_Full>
#1277: FILE: drivers/net/axgbe/axgbe_phy_impl.c:586:
+ pdata->phy.advertising &= ~ADVERTISED_10000baseT_Full;
CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Backplane>
#1646: FILE: drivers/net/axgbe/axgbe_phy_impl.c:955:
+ pdata->phy.lp_advertising |= ADVERTISED_Backplane;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->port_mode == AXGBE_PORT_MODE_SFP'
#1922: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231:
+ if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX'
#1922: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231:
+ if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR'
#1922: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231:
+ if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) &&
+ (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR))
total: 0 errors, 0 warnings, 15 checks, 2428 lines checked
parent reply other threads:[~2017-11-30 13:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1512047472-118050-6-git-send-email-Ravi1.kumar@amd.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130131339.1AF571B21D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ravi1.kumar@amd.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).