From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 1AF571B21D; Thu, 30 Nov 2017 14:13:39 +0100 (CET)
In-Reply-To: <1512047472-118050-6-git-send-email-Ravi1.kumar@amd.com>
References: <1512047472-118050-6-git-send-email-Ravi1.kumar@amd.com>
To: test-report@dpdk.org
Cc: Ravi Kumar <ravi1.kumar@amd.com>
Message-Id: <20171130131339.1AF571B21D@dpdk.org>
Date: Thu, 30 Nov 2017 14:13:39 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw31805 [PATCH 06/16] net/axgbe: add
	phy programming apis
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Nov 2017 13:13:39 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31805

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseKX_Full>
#535: FILE: drivers/net/axgbe/axgbe_mdio.c:591:
+		if (!(pdata->phy.advertising & ADVERTISED_1000baseKX_Full) &&

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_2500baseX_Full>
#536: FILE: drivers/net/axgbe/axgbe_mdio.c:592:
+		    !(pdata->phy.advertising & ADVERTISED_2500baseX_Full))

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseKR_Full>
#544: FILE: drivers/net/axgbe/axgbe_mdio.c:600:
+		if (!(pdata->phy.advertising & ADVERTISED_10000baseKR_Full))

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseR_FEC>
#682: FILE: drivers/net/axgbe/axgbe_mdio.c:738:
+	if (advertising & ADVERTISED_10000baseR_FEC)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Pause>
#706: FILE: drivers/net/axgbe/axgbe_mdio.c:762:
+	if (advertising & ADVERTISED_Pause)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Asym_Pause>
#711: FILE: drivers/net/axgbe/axgbe_mdio.c:767:
+	if (advertising & ADVERTISED_Asym_Pause)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pdata->phy.autoneg != AUTONEG_ENABLE'
#891: FILE: drivers/net/axgbe/axgbe_mdio.c:947:
+	if ((pdata->phy.autoneg != AUTONEG_ENABLE) || pdata->parallel_detect)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Autoneg>
#1272: FILE: drivers/net/axgbe/axgbe_phy_impl.c:581:
+	pdata->phy.advertising &= ~ADVERTISED_Autoneg;

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_100baseT_Full>
#1275: FILE: drivers/net/axgbe/axgbe_phy_impl.c:584:
+	pdata->phy.advertising &= ~ADVERTISED_100baseT_Full;

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseT_Full>
#1276: FILE: drivers/net/axgbe/axgbe_phy_impl.c:585:
+	pdata->phy.advertising &= ~ADVERTISED_1000baseT_Full;

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseT_Full>
#1277: FILE: drivers/net/axgbe/axgbe_phy_impl.c:586:
+	pdata->phy.advertising &= ~ADVERTISED_10000baseT_Full;

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Backplane>
#1646: FILE: drivers/net/axgbe/axgbe_phy_impl.c:955:
+	pdata->phy.lp_advertising |= ADVERTISED_Backplane;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->port_mode == AXGBE_PORT_MODE_SFP'
#1922: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231:
+	if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) &&
+	    (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) &&
+	    (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX'
#1922: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231:
+	if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) &&
+	    (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) &&
+	    (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR'
#1922: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1231:
+	if ((phy_data->port_mode == AXGBE_PORT_MODE_SFP) &&
+	    (phy_data->sfp_base != AXGBE_SFP_BASE_1000_CX) &&
+	    (phy_data->sfp_base != AXGBE_SFP_BASE_10000_CR))

total: 0 errors, 0 warnings, 15 checks, 2428 lines checked