From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 1D6867CE5; Fri, 1 Dec 2017 21:02:09 +0100 (CET) In-Reply-To: <1512158458-22661-3-git-send-email-erik.g.carrillo@intel.com> References: <1512158458-22661-3-git-send-email-erik.g.carrillo@intel.com> To: test-report@dpdk.org Cc: Erik Carrillo Message-Id: <20171201200209.1D6867CE5@dpdk.org> Date: Fri, 1 Dec 2017 21:02:09 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw31886 [PATCH RFC v5 2/5] eventtimer: add common code X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 20:02:09 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/31886 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #163: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:57: +#define ADAPTER_VALID_OR_ERR_RET(adapter, retval) do { \ + if (!adapter_valid(adapter)) \ + return retval; \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #168: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:62: +#define FUNC_PTR_OR_ERR_RET(func, errval) do { \ + if ((func) == NULL) \ + return errval; \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #173: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:67: +#define FUNC_PTR_OR_NULL_RET_WITH_ERRNO(func, errval) do { \ + if ((func) == NULL) { \ + rte_errno = errval; \ + return NULL; \ + } \ +} while (0) total: 0 errors, 3 warnings, 698 lines checked